From c9dbd42bd24b9020ffdd6410e584700f6f45c261 Mon Sep 17 00:00:00 2001 From: Florian Wilhelm Date: Tue, 11 Aug 2020 17:43:44 +0200 Subject: [PATCH 1/4] Prepare next development iteration --- release-notes-draft.md | 34 +--------------------------------- 1 file changed, 1 insertion(+), 33 deletions(-) diff --git a/release-notes-draft.md b/release-notes-draft.md index 1e919f0..19974bb 100644 --- a/release-notes-draft.md +++ b/release-notes-draft.md @@ -2,42 +2,10 @@ This document describes the changes which will be part of the next release and are already available in the latest version (master branch) of the pipeline. -# v40 +# v41 ## New Features -### Synopsys Detect Scan (formerly BlackDuck) (Beta) - -A new 3rd party stage was introduced which allows to execute Detect scans using the project "Piper" step [detectExecuteScan](https://sap.github.io/jenkins-library/steps/detectExecuteScan/). -Please note that the step is currently only available in an early version. -It might not support all variants of projects out-of-the-box. -Furthermore, you might have to configure a Docker image which provides the build tools, e.g. maven, that you want to use during the scan. - -The scan can be activated by configuring the step `detectExecuteScan`, for example: - -```yaml -steps: - detectExecuteScan: - detectTokenCredentialsId: 'detect-token' - projectName: 'My Example' - projectVersion: '1' - serverUrl: 'https://xyz.blackducksoftware.com' - dockerImage: 'docker-image' -``` - ## Fixes -Some stages such as `backendIntegrationTests` can be configured to run with an optional sidecar image. -This was broken for a number of releases, if the Download Cache was enabled and any steps within the stage made use of it (such as `mavenExecute`). -For the time being, docker containers can be connected to one network only, which means the Download Cache has to be disabled for stages with a sidecar image defined. - -In `scp-cf-spring` archetype maven-based MTA projects, the pipeline installed the wrong `application`-module artifact which broke the ability to run integration tests. -This was fixed in the [library](https://github.com/SAP/jenkins-library/pull/1892). - ## Improvements - -For a step which anticipates to run with an optional sidecar image, the image may now also be defined in that step's configuration only. -This improves performance versus configuring the sidecar image in the stage, since it avoids running other steps within the stage also with that sidecar. - -:warning: **If the Download Cache is enabled**, sidecar images have to be configured in the stage as before. -The Download Cache is enabled by default on CX-Server-based Jenkins instances, unless when running Jenkins in a Kubernetes environment. From 9991207af0341dd8d06eeb7e7fda359259cf90ce Mon Sep 17 00:00:00 2001 From: Kevin Hudemann Date: Wed, 12 Aug 2020 13:50:05 +0200 Subject: [PATCH 2/4] Remove sapNpmRegistry --- configuration.md | 1 - release-notes-draft.md | 12 ++++++++++++ 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/configuration.md b/configuration.md index ef57d29..d9eb261 100644 --- a/configuration.md +++ b/configuration.md @@ -648,7 +648,6 @@ The executeNpm step is used for all invocations of the npm build tool. It is, fo | --- | --- | --- | --- | | `dockerImage` | | `ppiper/node-browsers:v2` | The image to be used for executing npm commands. | | `defaultNpmRegistry` | | | The default npm registry url to be used as the remote mirror. Bypasses the local download cache if specified. | -| `sapNpmRegistry` | | `https://npm.sap.com` | The default npm registry url to be used as the remote mirror for the SAP npm packages. Bypasses the local download cache if specified. | #### cloudFoundryDeploy A step configuration regarding Cloud Foundry deployment. This is required by stages like end-to-end tests, performance tests, and production deployment. diff --git a/release-notes-draft.md b/release-notes-draft.md index 19974bb..81c60ee 100644 --- a/release-notes-draft.md +++ b/release-notes-draft.md @@ -4,6 +4,18 @@ This document describes the changes which will be part of the next release and a # v41 +## :warning: Breaking changes +### Configuration option for SAP NPM Registry +The configuration option `sapNpmRegistry` was removed, due to the migration of all packages from the SAP NPM registry to the default public registry at npmjs.org. +Thus, no separate configuration of the SAP NPM registry is required anymore. +Any configuration for the parameter `sapNpmRegistry` will be ignored by the pipeline. +If your project requires a custom registry configuration, use the `defaultNpmRegistry` parameter instead. For example: + +```diff + npmExecuteScripts: + defaultNpmRegistry: 'https://registry.npmjs.org/' +- sapNpmRegistry: 'https://...' +``` ## New Features ## Fixes From 460725a279932b0170b335a428c11ecd06b66a66 Mon Sep 17 00:00:00 2001 From: Stephan Assmus Date: Fri, 14 Aug 2020 14:50:59 +0200 Subject: [PATCH 3/4] Mention fix for stage-name misalignment --- release-notes-draft.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/release-notes-draft.md b/release-notes-draft.md index 81c60ee..0a78b70 100644 --- a/release-notes-draft.md +++ b/release-notes-draft.md @@ -8,7 +8,7 @@ This document describes the changes which will be part of the next release and a ### Configuration option for SAP NPM Registry The configuration option `sapNpmRegistry` was removed, due to the migration of all packages from the SAP NPM registry to the default public registry at npmjs.org. Thus, no separate configuration of the SAP NPM registry is required anymore. -Any configuration for the parameter `sapNpmRegistry` will be ignored by the pipeline. +Any configuration for the parameter `sapNpmRegistry` **will be ignored** by the pipeline. If your project requires a custom registry configuration, use the `defaultNpmRegistry` parameter instead. For example: ```diff @@ -20,4 +20,6 @@ If your project requires a custom registry configuration, use the `defaultNpmReg ## Fixes +The frontend integration tests where not run in versions v39 and v40 of the pipeline, because the technical name of the stage was not correctly passed to the new go-implemented steps introduced in v39. The stage Frontend Integration Tests was nevertheless shown as successful. + ## Improvements From 843c2de87c1712bab65b6362d615d34492db166c Mon Sep 17 00:00:00 2001 From: s4sdkJenkinsBot Date: Mon, 17 Aug 2020 14:07:32 +0000 Subject: [PATCH 4/4] Set release version v41 --- s4sdk-pipeline.groovy | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/s4sdk-pipeline.groovy b/s4sdk-pipeline.groovy index dadfcd5..05c9246 100644 --- a/s4sdk-pipeline.groovy +++ b/s4sdk-pipeline.groovy @@ -1,6 +1,6 @@ #!/usr/bin/env groovy -final def pipelineSdkVersion = 'master' +final def pipelineSdkVersion = 'v41' library "s4sdk-pipeline-library@${pipelineSdkVersion}" cloudSdkPipeline(script: this)