Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AnalyticalListPage #302

Merged
merged 30 commits into from Oct 28, 2022
Merged

AnalyticalListPage #302

merged 30 commits into from Oct 28, 2022

Conversation

@stewsk stewsk changed the title Alp AnalyticalListPage Oct 6, 2022
@gregorwolf
Copy link
Contributor

Hi @stewsk ,

thank you for this example. Maybe you have some tips in Analytical List Page fails with Error: adding element with duplicate id for OData V4 endpoint how I can get my ALP working.

Best Regards
Gregor

stewsk and others added 14 commits October 13, 2022 18:47
hack: made all the currencies EUR because otherwise KPIs don't work
also: adding a quantity with unit to compare with price/currency
-> QwithUnit is right aligned, price with currency is not
* data: set all currencies to USD and remove deciomals for price
* add another "fieldWithCurrency" that looks exactly like in th
  Fiori FeatureShowcase app
+ fix flight data
+ change default for chart
* sett route in ui5.yaml
* workaround needed, apparently Java has a problem with the
  to_Flight association in Bookings
+ label for "fake" currency code
@stewsk stewsk marked this pull request as ready for review October 20, 2022 17:36
@@ -0,0 +1,18 @@
<edmx:Edmx xmlns:edmx="http://docs.oasis-open.org/odata/ns/edmx" Version="4.0">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why isn't that generated by us as part of 2edmx?

Copy link
Collaborator Author

@stewsk stewsk Oct 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

file seems to be unnecessary, not present in travel_processor -> removed

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@c-kobo @stefan0816 : this file seems to be unnecessary for a CAP app -> can the generation tool in vs code be changed so that this file isn't generated anymore?

@@ -0,0 +1,130 @@
<?xml version="1.0" encoding="utf-8"?>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why isn't that generated by us as part of 2edmx?

Copy link
Collaborator Author

@stewsk stewsk Oct 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

file seems to be unnecessary, not present in travel_processor -> removed

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@c-kobo @stefan0816 : this file seems to be unnecessary for a CAP app -> can the generation tool in vs code be changed so that this file isn't generated anymore?

package.json Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
Comment on lines +39 to +53
// Java has a problem with this association
to_Flight,

// Workaround:
to_Flight.PlaneType,
to_Flight.to_Connection.Distance,
to_Flight.to_Connection.DistanceUnit,
@Common.Label: '{i18n>DepartureAirport}'
@Common.Text: DepCity
to_Flight.to_Connection.DepartureAirport.AirportID as DepAirport,
to_Flight.to_Connection.DepartureAirport.City as DepCity,
@Common.Label: '{i18n>ArrivalAirport}'
@Common.Text: DestCity
to_Flight.to_Connection.DestinationAirport.AirportID as DestAirport,
to_Flight.to_Connection.DestinationAirport.City as DestCity,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is Java working on fixing the root cause?
We should always remove workarounds, as soon as possible.

@BraunMatthias

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stewsk
Copy link
Collaborator Author

stewsk commented Oct 24, 2022

The "Fiori Application Generator" in VS Code generated some files that seem to be unnecessary for a CAP app (and which are not present in the travel_processor app):

  • webapp/annotations/annotation.xml
  • webapp/localService/metadata.xml
  • webapp/manifest_all_json

I have removed these files with commit ee4d869

@c-kobo @stefan0816 : can you verify that removing these files is ok? If they are indeed unnecessary, can the "Fiori App Generator" be adapted to not generate these files in the first place?

Co-authored-by: Daniel Hutzel <daniel.hutzel@sap.com>
@johannes-vogel
Copy link
Contributor

looks good from runtime side.
I wonder why the UI Tests fail...

@stewsk
Copy link
Collaborator Author

stewsk commented Oct 28, 2022

I wonder why the UI Tests fail...

The tests are unstable. That would be a topic for our next sync.

@stewsk stewsk merged commit d7ec661 into main Oct 28, 2022
@stewsk stewsk deleted the alp branch October 28, 2022 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants