Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Folder structure #109

Closed
larshp opened this issue Jul 8, 2021 · 6 comments
Closed

Folder structure #109

larshp opened this issue Jul 8, 2021 · 6 comments

Comments

@larshp
Copy link
Collaborator

larshp commented Jul 8, 2021

Example: https://github.com/SAP/abap-file-formats/tree/main/file-formats/chkc

it contains
image

the source is under type and the first file in the folder is the auto generated json schema file

Suggest:
A: Move the ABAP source to the root of the object type folder
B: Move the auto generated json schema to a new folder generated under the object type
C: Change the filename of the auto generated json schema, eg zif_atc_aff_chkc_v1.json to make it easier for users to tell the relationship between files

@larshp
Copy link
Collaborator Author

larshp commented Jul 14, 2021

alternatively, move the ABAP type to the same folder level as the generated JSON

@albertmink
Copy link
Contributor

We could start with option B. The folder name would suggest not to edit the json-schema manually as raised in #110.

@schneidermic0
Copy link
Contributor

As long as we keep the reference to the schema file (jn the $schema field) we should be careful with names and folders.

I would prefer not to use the interface name for the json-schema file. At least as long as we are referring to it in the files. But we should add the version (like chkc-v1.json or chic.v1.json)

But, maybe, it makes sense to move all generated json schemas to one dedicated folder and keep the folder structure of object types only for the ABAP types, the format documentation and the example. E.g., /schema/chkc-v1.json.

@larshp
Copy link
Collaborator Author

larshp commented Jul 16, 2021

I'd like to remove the $schema field and add a version field instead, #53

@larshp larshp mentioned this issue Jul 19, 2021
@schneidermic0
Copy link
Contributor

Let's continue with this issue as soon as #53 is solved.

@albertmink
Copy link
Contributor

Update:

I feel as if the above discussion is outdated, due to the evolution of the repository and will close the issue.
Feel free to reopen the issue 👋

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants