Skip to content

[AIFD] - React on UX crosscheck review #667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 9, 2024
Merged

[AIFD] - React on UX crosscheck review #667

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
be47b89
AIFD - React on UX crosscheck review
D047539 Oct 8, 2024
0d4fb44
Merge branch 'main' into feature/aifd
albertmink Oct 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions file-formats/aifd/aifd-v1.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,25 +54,25 @@
"originalLanguage"
]
},
"aifInterfaces": {
"title": "AIF Interfaces",
"description": "AIF interfaces",
"applicationInterfaces": {
"title": "Application Interfaces",
"description": "Application interfaces",
"type": "array",
"items": {
"title": "AIF Interface",
"description": "AIF interface",
"title": "Application Interface",
"description": "Application interface",
"type": "object",
"properties": {
"interfaceObjectName": {
"title": "Interface Object Name",
"description": "Interface object name",
"applicationInterface": {
"title": "Application Interface",
"description": "Application interface",
"type": "string",
"maxLength": 40
}
},
"additionalProperties": false,
"required": [
"interfaceObjectName"
"applicationInterface"
]
}
}
Expand All @@ -81,6 +81,6 @@
"required": [
"formatVersion",
"header",
"aifInterfaces"
"applicationInterfaces"
]
}
8 changes: 4 additions & 4 deletions file-formats/aifd/examples/z_aff_example_aifd.aifd.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,15 @@
"originalLanguage": "en",
"abapLanguageVersion": "cloudDevelopment"
},
"aifInterfaces":[
"applicationInterfaces":[
{
"interfaceObjectName":"INT_OBJ_1"
"applicationInterface":"INT_OBJ_1"
},
{
"interfaceObjectName":"/AIFTCUST_WS_I00001"
"applicationInterface":"/AIFTCUST_WS_I00001"
},
{
"interfaceObjectName":"/AIFTCUST_WS_O00001"
"applicationInterface":"/AIFTCUST_WS_O00001"
}
]
}
30 changes: 15 additions & 15 deletions file-formats/aifd/type/zif_aff_aifd_v1.intf.abap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,31 +1,31 @@
INTERFACE zif_aff_aifd_v1
PUBLIC.
TYPES:
"! <p class="shorttext">AIF Interface</p>
"! AIF interface
BEGIN OF ty_aif_interface,
"! <p class="shorttext">Interface Object Name</p>
"! Interface object name
"! <p class="shorttext">Application Interface</p>
"! Application interface
BEGIN OF ty_application_interface,
"! <p class="shorttext">Application Interface</p>
"! Application interface
"! $required
interface_object_name TYPE c LENGTH 40,
END OF ty_aif_interface,
application_interface TYPE c LENGTH 40,
END OF ty_application_interface,

"! <p class="shorttext">AIF Interfaces</p>
"! AIF interfaces
ty_aif_interfaces TYPE STANDARD TABLE OF ty_aif_interface WITH DEFAULT KEY,
"! <p class="shorttext">Application Interfaces</p>
"! Application interfaces
ty_application_interfaces TYPE STANDARD TABLE OF ty_application_interface WITH DEFAULT KEY,

"! <p class="shorttext">Deployment Scenario</p>
"! Deployment scenario
BEGIN OF ty_main,
"! $required
format_version TYPE zif_aff_types_v1=>ty_format_version,
format_version TYPE zif_aff_types_v1=>ty_format_version,
"! <p class="shorttext">Header</p>
"! Header
"! $required
header TYPE zif_aff_types_v1=>ty_header_60_cloud,
"! <p class="shorttext">AIF Interfaces</p>
"! AIF interfaces
header TYPE zif_aff_types_v1=>ty_header_60_cloud,
"! <p class="shorttext">Application Interfaces</p>
"! Application interfaces
"! $required
aif_interfaces TYPE ty_aif_interfaces,
application_interfaces TYPE ty_application_interfaces,
END OF ty_main.
ENDINTERFACE.