From a68f2cb70b84514d0ec4cf7e929bd002b2f27404 Mon Sep 17 00:00:00 2001
From: WUEHR <111513386+WUEHR@users.noreply.github.com>
Date: Tue, 10 Jun 2025 17:32:34 +0200
Subject: [PATCH 1/5] Add files for HTTP

---
 file-formats/http/README.md                   | 13 +++
 file-formats/http/http-v1.json                | 90 +++++++++++++++++++
 .../http/type/zif_aff_http_v1.intf.abap       | 38 ++++++++
 .../http/type/zif_aff_http_v1.intf.json       |  7 ++
 4 files changed, 148 insertions(+)
 create mode 100644 file-formats/http/README.md
 create mode 100644 file-formats/http/http-v1.json
 create mode 100644 file-formats/http/type/zif_aff_http_v1.intf.abap
 create mode 100644 file-formats/http/type/zif_aff_http_v1.intf.json

diff --git a/file-formats/http/README.md b/file-formats/http/README.md
new file mode 100644
index 000000000..7c4a69063
--- /dev/null
+++ b/file-formats/http/README.md
@@ -0,0 +1,13 @@
+# HTTP Service File Format
+
+## Object Type Information
+
+Object Type | Description | Group
+:--- | :--- | :---
+HTTP  | HTTP Service | Connectivity
+
+## File Structure
+
+File | Cardinality | Definition | Schema | Example
+:--- | :--- | :--- | :--- | :---
+`<name>.http.json` | 1 | [`zif_aff_http_v1.intf.abap`](./type/zif_aff_http_v1.intf.abap) | [`http-v1.json`](./http-v1.json)
diff --git a/file-formats/http/http-v1.json b/file-formats/http/http-v1.json
new file mode 100644
index 000000000..f22b7642f
--- /dev/null
+++ b/file-formats/http/http-v1.json
@@ -0,0 +1,90 @@
+{
+  "$comment": "This file is autogenerated, do not edit manually, see https://github.com/SAP/abap-file-formats for more information.",
+  "$schema": "https://json-schema.org/draft/2020-12/schema",
+  "$id": "https://github.com/SAP/abap-file-formats/blob/main/file-formats/http/http-v1.json",
+  "title": "HTTP Service",
+  "description": "Creation of HTTP Service",
+  "type": "object",
+  "properties": {
+    "formatVersion": {
+      "title": "Format Version",
+      "description": "Format version",
+      "type": "string",
+      "const": "1"
+    },
+    "header": {
+      "title": "Header",
+      "description": "Header",
+      "type": "object",
+      "properties": {
+        "description": {
+          "title": "Description",
+          "description": "Description of the ABAP object",
+          "type": "string",
+          "maxLength": 60
+        },
+        "originalLanguage": {
+          "title": "Original Language",
+          "description": "Original language of the ABAP object",
+          "type": "string",
+          "minLength": 2
+        },
+        "abapLanguageVersion": {
+          "title": "ABAP Language Version",
+          "description": "ABAP language version",
+          "type": "string",
+          "enum": [
+            "standard",
+            "cloudDevelopment"
+          ],
+          "enumTitles": [
+            "Standard",
+            "ABAP Cloud Development"
+          ],
+          "enumDescriptions": [
+            "Standard",
+            "ABAP cloud development"
+          ],
+          "default": "standard"
+        }
+      },
+      "additionalProperties": false,
+      "required": [
+        "description",
+        "originalLanguage"
+      ]
+    },
+    "configuration": {
+      "title": "General Information",
+      "description": "General information",
+      "type": "object",
+      "properties": {
+        "serviceName": {
+          "title": "Name",
+          "description": "Name",
+          "type": "string",
+          "maxLength": 30
+        },
+        "serviceClass": {
+          "title": "Handler Class",
+          "description": "Handler class",
+          "type": "string",
+          "maxLength": 30
+        },
+        "serviceUrl": {
+          "title": "URL",
+          "description": "URL",
+          "type": "string",
+          "maxLength": 30
+        }
+      },
+      "additionalProperties": false
+    }
+  },
+  "additionalProperties": false,
+  "required": [
+    "formatVersion",
+    "header",
+    "configuration"
+  ]
+}
diff --git a/file-formats/http/type/zif_aff_http_v1.intf.abap b/file-formats/http/type/zif_aff_http_v1.intf.abap
new file mode 100644
index 000000000..cb5150887
--- /dev/null
+++ b/file-formats/http/type/zif_aff_http_v1.intf.abap
@@ -0,0 +1,38 @@
+INTERFACE zif_aff_http_v1
+ PUBLIC.
+
+  TYPES:
+    "! <p class="shorttext">General Information</p>
+    "! General information
+    "! $required
+    BEGIN OF ty_configuration,
+      "! <p class="shorttext">Name</p>
+      "! Name
+      service_name  TYPE zif_aff_types_v1=>ty_object_name_30,
+      "! <p class="shorttext">Handler Class</p>
+      "! Handler class
+      service_class TYPE zif_aff_types_v1=>ty_object_name_30,
+      "! <p class="shorttext">URL</p>
+      "! URL
+      service_url   TYPE zif_aff_types_v1=>ty_object_name_30,
+    END OF ty_configuration.
+
+  TYPES:
+    "! <p class="shorttext">HTTP Service</p>
+    "! Creation of HTTP Service
+    BEGIN OF ty_main,
+      "! <p class="shorttext">Format Version</p>
+      "! Format version
+      "! $required
+      format_version TYPE zif_aff_types_v1=>ty_format_version,
+      "! <p class="shorttext">Header</p>
+      "! Header
+      "! $required
+      header         TYPE zif_aff_types_v1=>ty_header_60_cloud,
+      "! <p class="shorttext">General Information</p>
+      "! General information
+      "! $required
+      configuration  TYPE ty_configuration,
+
+    END OF ty_main.
+ENDINTERFACE.
diff --git a/file-formats/http/type/zif_aff_http_v1.intf.json b/file-formats/http/type/zif_aff_http_v1.intf.json
new file mode 100644
index 000000000..16984c4be
--- /dev/null
+++ b/file-formats/http/type/zif_aff_http_v1.intf.json
@@ -0,0 +1,7 @@
+{
+  "formatVersion": "1",
+  "header": {
+    "description": "ABAP File Format for HTTP Service",
+    "originalLanguage": "en"
+  }
+}

From d241275335d9e025121951bda910f77679b6203f Mon Sep 17 00:00:00 2001
From: WUEHR <111513386+WUEHR@users.noreply.github.com>
Date: Tue, 10 Jun 2025 17:35:41 +0200
Subject: [PATCH 2/5] Update indentation

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
---
 file-formats/http/type/zif_aff_http_v1.intf.abap | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/file-formats/http/type/zif_aff_http_v1.intf.abap b/file-formats/http/type/zif_aff_http_v1.intf.abap
index cb5150887..55f62926f 100644
--- a/file-formats/http/type/zif_aff_http_v1.intf.abap
+++ b/file-formats/http/type/zif_aff_http_v1.intf.abap
@@ -1,5 +1,5 @@
 INTERFACE zif_aff_http_v1
- PUBLIC.
+  PUBLIC.
 
   TYPES:
     "! <p class="shorttext">General Information</p>

From d16676fa42bbaee1c7e65eb05d2fad7ef5c11f7c Mon Sep 17 00:00:00 2001
From: WUEHR <111513386+WUEHR@users.noreply.github.com>
Date: Wed, 11 Jun 2025 16:57:31 +0200
Subject: [PATCH 3/5] Corrections from review

---
 file-formats/http/http-v1.json                | 18 ++++++------------
 .../http/type/zif_aff_http_v1.intf.abap       | 19 ++++++++-----------
 2 files changed, 14 insertions(+), 23 deletions(-)

diff --git a/file-formats/http/http-v1.json b/file-formats/http/http-v1.json
index f22b7642f..138c65eca 100644
--- a/file-formats/http/http-v1.json
+++ b/file-formats/http/http-v1.json
@@ -3,7 +3,7 @@
   "$schema": "https://json-schema.org/draft/2020-12/schema",
   "$id": "https://github.com/SAP/abap-file-formats/blob/main/file-formats/http/http-v1.json",
   "title": "HTTP Service",
-  "description": "Creation of HTTP Service",
+  "description": "HTTP Service",
   "type": "object",
   "properties": {
     "formatVersion": {
@@ -54,28 +54,22 @@
         "originalLanguage"
       ]
     },
-    "configuration": {
+    "generalInformation": {
       "title": "General Information",
       "description": "General information",
       "type": "object",
       "properties": {
-        "serviceName": {
-          "title": "Name",
-          "description": "Name",
-          "type": "string",
-          "maxLength": 30
-        },
-        "serviceClass": {
+        "handlerClass": {
           "title": "Handler Class",
           "description": "Handler class",
           "type": "string",
           "maxLength": 30
         },
-        "serviceUrl": {
+        "url": {
           "title": "URL",
           "description": "URL",
           "type": "string",
-          "maxLength": 30
+          "maxLength": 60
         }
       },
       "additionalProperties": false
@@ -85,6 +79,6 @@
   "required": [
     "formatVersion",
     "header",
-    "configuration"
+    "generalInformation"
   ]
 }
diff --git a/file-formats/http/type/zif_aff_http_v1.intf.abap b/file-formats/http/type/zif_aff_http_v1.intf.abap
index 55f62926f..1c55f2be6 100644
--- a/file-formats/http/type/zif_aff_http_v1.intf.abap
+++ b/file-formats/http/type/zif_aff_http_v1.intf.abap
@@ -5,34 +5,31 @@ INTERFACE zif_aff_http_v1
     "! <p class="shorttext">General Information</p>
     "! General information
     "! $required
-    BEGIN OF ty_configuration,
-      "! <p class="shorttext">Name</p>
-      "! Name
-      service_name  TYPE zif_aff_types_v1=>ty_object_name_30,
+    BEGIN OF ty_general_information,
       "! <p class="shorttext">Handler Class</p>
       "! Handler class
-      service_class TYPE zif_aff_types_v1=>ty_object_name_30,
+      handler_class TYPE zif_aff_types_v1=>ty_object_name_30,
       "! <p class="shorttext">URL</p>
       "! URL
-      service_url   TYPE zif_aff_types_v1=>ty_object_name_30,
-    END OF ty_configuration.
+      url           TYPE c LENGTH 60,
+    END OF ty_general_information.
 
   TYPES:
     "! <p class="shorttext">HTTP Service</p>
-    "! Creation of HTTP Service
+    "! HTTP Service
     BEGIN OF ty_main,
       "! <p class="shorttext">Format Version</p>
       "! Format version
       "! $required
-      format_version TYPE zif_aff_types_v1=>ty_format_version,
+      format_version      TYPE zif_aff_types_v1=>ty_format_version,
       "! <p class="shorttext">Header</p>
       "! Header
       "! $required
-      header         TYPE zif_aff_types_v1=>ty_header_60_cloud,
+      header              TYPE zif_aff_types_v1=>ty_header_60_cloud,
       "! <p class="shorttext">General Information</p>
       "! General information
       "! $required
-      configuration  TYPE ty_configuration,
+      general_information TYPE ty_general_information,
 
     END OF ty_main.
 ENDINTERFACE.

From 7a9a0739801d0c41f09d989fda046f6b94bd7562 Mon Sep 17 00:00:00 2001
From: WUEHR <111513386+WUEHR@users.noreply.github.com>
Date: Thu, 12 Jun 2025 13:27:15 +0200
Subject: [PATCH 4/5] Increase length of URL field

---
 file-formats/http/http-v1.json                   | 2 +-
 file-formats/http/type/zif_aff_http_v1.intf.abap | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/file-formats/http/http-v1.json b/file-formats/http/http-v1.json
index 138c65eca..2e88fae95 100644
--- a/file-formats/http/http-v1.json
+++ b/file-formats/http/http-v1.json
@@ -69,7 +69,7 @@
           "title": "URL",
           "description": "URL",
           "type": "string",
-          "maxLength": 60
+          "maxLength": 120
         }
       },
       "additionalProperties": false
diff --git a/file-formats/http/type/zif_aff_http_v1.intf.abap b/file-formats/http/type/zif_aff_http_v1.intf.abap
index 1c55f2be6..050b015ef 100644
--- a/file-formats/http/type/zif_aff_http_v1.intf.abap
+++ b/file-formats/http/type/zif_aff_http_v1.intf.abap
@@ -11,7 +11,7 @@ INTERFACE zif_aff_http_v1
       handler_class TYPE zif_aff_types_v1=>ty_object_name_30,
       "! <p class="shorttext">URL</p>
       "! URL
-      url           TYPE c LENGTH 60,
+      url           TYPE c LENGTH 120,
     END OF ty_general_information.
 
   TYPES:

From 831291f279646f844a5a19a3419ee41bb77b39e4 Mon Sep 17 00:00:00 2001
From: WUEHR <111513386+WUEHR@users.noreply.github.com>
Date: Tue, 17 Jun 2025 13:27:50 +0200
Subject: [PATCH 5/5] Delete URL

---
 file-formats/http/http-v1.json                   | 6 ------
 file-formats/http/type/zif_aff_http_v1.intf.abap | 3 ---
 2 files changed, 9 deletions(-)

diff --git a/file-formats/http/http-v1.json b/file-formats/http/http-v1.json
index 2e88fae95..627715599 100644
--- a/file-formats/http/http-v1.json
+++ b/file-formats/http/http-v1.json
@@ -64,12 +64,6 @@
           "description": "Handler class",
           "type": "string",
           "maxLength": 30
-        },
-        "url": {
-          "title": "URL",
-          "description": "URL",
-          "type": "string",
-          "maxLength": 120
         }
       },
       "additionalProperties": false
diff --git a/file-formats/http/type/zif_aff_http_v1.intf.abap b/file-formats/http/type/zif_aff_http_v1.intf.abap
index 050b015ef..8cb02e25e 100644
--- a/file-formats/http/type/zif_aff_http_v1.intf.abap
+++ b/file-formats/http/type/zif_aff_http_v1.intf.abap
@@ -9,9 +9,6 @@ INTERFACE zif_aff_http_v1
       "! <p class="shorttext">Handler Class</p>
       "! Handler class
       handler_class TYPE zif_aff_types_v1=>ty_object_name_30,
-      "! <p class="shorttext">URL</p>
-      "! URL
-      url           TYPE c LENGTH 120,
     END OF ty_general_information.
 
   TYPES: