Skip to content

Conversation

@KarstenSchnitter
Copy link
Contributor

Each PR should be built with mvn clean verify to execute the integration tests. This helps PR validation.

Each PR should be built with `mvn clean verify` to execute the integration tests. This helps PR validation.
The release-4 branch is based on Java 17. Only PRs against this PR
are compatible with the workflow setup.

Signed-off-by: Karsten Schnitter <k.schnitter@sap.com>
The main branch requires a different build:

- use JDK 11
- separate clean & verify Maven command

Signed-off-by: Karsten Schnitter <k.schnitter@sap.com>
Currently the checks should be tested with the release-4 branch.
Fixes for the main branch will be done separately.

Signed-off-by: Karsten Schnitter <k.schnitter@sap.com>
on:
pull_request:
branches:
# - main
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# - main
- main

Why is this commented out?

@juergen-walter
Copy link
Member

@juergen-walter juergen-walter self-requested a review October 28, 2025 12:13
@KarstenSchnitter KarstenSchnitter merged commit d7fd784 into main Oct 28, 2025
2 checks passed
@KarstenSchnitter KarstenSchnitter deleted the workflow-maven-verify branch October 28, 2025 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants