Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Principal Propagation does not work in node.js v.10 (default in BTP CF). #1288

Closed
carlonnheim opened this issue May 11, 2021 · 4 comments
Closed
Assignees
Labels
question Further information is requested

Comments

@carlonnheim
Copy link

See the issue posted here:
https://answers.sap.com/questions/13382012/principal-propagation-works-in-bas-but-not-when-de.html

@carlonnheim carlonnheim added the bug Something isn't working label May 11, 2021
@jjtang1985
Copy link
Contributor

jjtang1985 commented May 11, 2021

Hi @carlonnheim ,

thank you for reaching us.

I checked the link provided. Here are some comments from my side:

  • The log says, No user token (JWT) has been provided! This is strictly necessary for principal propagation., which seems to be a CAP issue or CF configuration issue, because without JWT, there is nothing the SAP Cloud SDK can do.
  • Adding the node version to the package.json as a fix seems also like a CAP issue, because the SDK does not need this.
  • CAP does not support node 10, and you have to use node 14 or newer version, which seems to be related to your fix.
  • Actually the end of life of node 10 is 30-04-2021, I guess CF should not use v.10 as default version.

May I ask you to create an issue here as the support channel of CAP?

Best reagards,
Junjie

@gregorwolf
Copy link

Hi @jjtang1985 ,

I would suggest to not use links to internal SAP websites.

Best regards
Gregor

@jjtang1985
Copy link
Contributor

jjtang1985 commented May 12, 2021

Hi @gregorwolf,
good catch, I updated the link.
Thank you very much.
Best regards,
Junjie

@carlonnheim
Copy link
Author

Hi,

Ok, makes sense. Then this is more of a caveat than a bug (CAP requiring node 14 but the BTP running node 10 by default). Let us close this. Anyone struggling with the same issue will hopefully find the forum post.

Thanks for your feedback and your work on this product, it is an awesome framework!
//Carl

@jjtang1985 jjtang1985 self-assigned this May 14, 2021
@jjtang1985 jjtang1985 added question Further information is requested and removed bug Something isn't working labels May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants