From 50c5b6bae62f8094249a7735017cff91da0b504a Mon Sep 17 00:00:00 2001 From: Lucas Borin <5233413+lucasborin@users.noreply.github.com> Date: Wed, 7 Oct 2020 22:04:38 +0200 Subject: [PATCH 1/2] disabling coverages in test code --- src/checks/y_check_branch_coverage.clas.abap | 2 +- src/checks/y_check_procedure_coverage.clas.abap | 2 +- src/checks/y_check_statement_coverage.clas.abap | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/checks/y_check_branch_coverage.clas.abap b/src/checks/y_check_branch_coverage.clas.abap index 37bcefa4..c9eea4c9 100644 --- a/src/checks/y_check_branch_coverage.clas.abap +++ b/src/checks/y_check_branch_coverage.clas.abap @@ -18,7 +18,7 @@ CLASS y_check_branch_coverage IMPLEMENTATION. settings-threshold = 100. settings-is_threshold_reversed = abap_true. settings-disable_on_prodcode_selection = abap_true. - settings-disable_on_testcode_selection = abap_true. + settings-disable_on_testcode_selection = abap_false. settings-documentation = |{ c_docs_path-checks }unit-test-coverages.md|. set_check_message( 'Branch Coverage of &1% is under the threshold of &2%.' ). diff --git a/src/checks/y_check_procedure_coverage.clas.abap b/src/checks/y_check_procedure_coverage.clas.abap index 5652f6e6..6a389c7e 100644 --- a/src/checks/y_check_procedure_coverage.clas.abap +++ b/src/checks/y_check_procedure_coverage.clas.abap @@ -18,7 +18,7 @@ CLASS y_check_procedure_coverage IMPLEMENTATION. settings-threshold = 100. settings-is_threshold_reversed = abap_true. settings-disable_on_prodcode_selection = abap_true. - settings-disable_on_testcode_selection = abap_true. + settings-disable_on_testcode_selection = abap_false. settings-documentation = |{ c_docs_path-checks }unit-test-coverages.md|. set_check_message( 'Procedure Coverage of &1% is under the threshold of &2%.' ). diff --git a/src/checks/y_check_statement_coverage.clas.abap b/src/checks/y_check_statement_coverage.clas.abap index ea02ce31..7af9cc9b 100644 --- a/src/checks/y_check_statement_coverage.clas.abap +++ b/src/checks/y_check_statement_coverage.clas.abap @@ -18,7 +18,7 @@ CLASS y_check_statement_coverage IMPLEMENTATION. settings-threshold = 100. settings-is_threshold_reversed = abap_true. settings-disable_on_prodcode_selection = abap_true. - settings-disable_on_testcode_selection = abap_true. + settings-disable_on_testcode_selection = abap_false. settings-documentation = |{ c_docs_path-checks }unit-test-coverages.md|. set_check_message( 'Statement Coverage of &1% is under the threshold of &2%.' ). From e8cc783bdb7f850137cd1a4595345cd6aeeb99b9 Mon Sep 17 00:00:00 2001 From: Lucas Borin <5233413+lucasborin@users.noreply.github.com> Date: Thu, 8 Oct 2020 15:56:07 +0200 Subject: [PATCH 2/2] disabling apply on test code --- src/checks/y_check_branch_coverage.clas.abap | 3 ++- src/checks/y_check_procedure_coverage.clas.abap | 3 ++- src/checks/y_check_statement_coverage.clas.abap | 3 ++- 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/src/checks/y_check_branch_coverage.clas.abap b/src/checks/y_check_branch_coverage.clas.abap index c9eea4c9..ce6077c4 100644 --- a/src/checks/y_check_branch_coverage.clas.abap +++ b/src/checks/y_check_branch_coverage.clas.abap @@ -18,7 +18,8 @@ CLASS y_check_branch_coverage IMPLEMENTATION. settings-threshold = 100. settings-is_threshold_reversed = abap_true. settings-disable_on_prodcode_selection = abap_true. - settings-disable_on_testcode_selection = abap_false. + settings-disable_on_testcode_selection = abap_true. + settings-apply_on_test_code = abap_false. settings-documentation = |{ c_docs_path-checks }unit-test-coverages.md|. set_check_message( 'Branch Coverage of &1% is under the threshold of &2%.' ). diff --git a/src/checks/y_check_procedure_coverage.clas.abap b/src/checks/y_check_procedure_coverage.clas.abap index 6a389c7e..8a6afb16 100644 --- a/src/checks/y_check_procedure_coverage.clas.abap +++ b/src/checks/y_check_procedure_coverage.clas.abap @@ -18,7 +18,8 @@ CLASS y_check_procedure_coverage IMPLEMENTATION. settings-threshold = 100. settings-is_threshold_reversed = abap_true. settings-disable_on_prodcode_selection = abap_true. - settings-disable_on_testcode_selection = abap_false. + settings-disable_on_testcode_selection = abap_true. + settings-apply_on_test_code = abap_false. settings-documentation = |{ c_docs_path-checks }unit-test-coverages.md|. set_check_message( 'Procedure Coverage of &1% is under the threshold of &2%.' ). diff --git a/src/checks/y_check_statement_coverage.clas.abap b/src/checks/y_check_statement_coverage.clas.abap index 7af9cc9b..00f5d56d 100644 --- a/src/checks/y_check_statement_coverage.clas.abap +++ b/src/checks/y_check_statement_coverage.clas.abap @@ -18,7 +18,8 @@ CLASS y_check_statement_coverage IMPLEMENTATION. settings-threshold = 100. settings-is_threshold_reversed = abap_true. settings-disable_on_prodcode_selection = abap_true. - settings-disable_on_testcode_selection = abap_false. + settings-disable_on_testcode_selection = abap_true. + settings-apply_on_test_code = abap_false. settings-documentation = |{ c_docs_path-checks }unit-test-coverages.md|. set_check_message( 'Statement Coverage of &1% is under the threshold of &2%.' ).