Skip to content

Feat/system tests on windows #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mhaas merged 7 commits into from
Jul 2, 2020
Merged

Feat/system tests on windows #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
da0bb88
Run system tests on windows
mhaas Jul 2, 2020
38729d5
Temporarily enable system tests on PRs
mhaas Jul 2, 2020
5beefc4
Merge remote-tracking branch 'origin/master' into feat/system-tests-o…
mhaas Jul 2, 2020
01ba1ec
Revert "Temporarily enable system tests on PRs"
mhaas Jul 2, 2020
3d434a2
README: update package name
mhaas Jul 2, 2020
c428432
Encrypt email addresses
mhaas Jul 2, 2020
4da4154
Update CHANGELOG
mhaas Jul 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 15 additions & 5 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,15 @@ notifications:
if: branch = master AND type != pull_request
on_failure: always
recipients:
michael.haas01@sap.com
karthik.muthuswamy@sap.com
francesco.alda@sap.com
evgeny.arnautov@sap.com
# Michael
Copy link
Contributor Author

@mhaas mhaas Jul 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EvgenyArn This should be better!

Copy link
Contributor

@karthikmswamy karthikmswamy Jul 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's this? And, is this a hash of the email address?

Copy link
Contributor

@karthikmswamy karthikmswamy Jul 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My question is more out of curiosity than a question :)

Copy link

@EvgenyArn EvgenyArn Jul 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mhaas looks fancy, what is it? :)

Copy link
Contributor Author

@mhaas mhaas Jul 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EvgenyArn In Travis, each repo has an associated public and private key pair. I can encrypt data with the public key, and Travis can decrypt it with the private key. This is also how credentials are handled for pypi upload and for the DAR service key used for the system tests :)

- secure: "r05MU3AGjL+KMQSy3s3PW2tm3qA/ElRKQalMuixr3a1EJr6ZOb+FV2jRWM25q/2x5U/yszigtAKDuuF/Y/gbpIp4UwfhF9iTi7INF05F32E2SZAjnxA7rWJU294CR51J9UOYCaYt0fWPEt0IZMXl5rp1ORarNgLB2m33ZZKVzTr2ArSVBh/TvduymK1nEwTuA148fPQXobMCM6NF5qyVmxaoRWVQPVqafpmjSum+1k5qcZVFOHrix9hKFgJNZ/BrQu3w7lpu1HWpVoSr8wf1ZOt5VIeNL8NZBNM6vIQxdlOWpm9/ooTW/oKCuYuKs4aLp/AwJsrwJdYAls7TobyRlUh0u7HXj5+S4+BadlxgpKLWEV7KEPYgpIFvHEv2rcQUFQY7K4j+9U7wr4uxqUUaSvykYlipu+50pJshZjxKjx6frRFojjeaJNGmsL6ekK5ADrEWvbdhsnMG5SMbbWKrX9TFHv/HOwZuCQMsX/Noqnicxy0jt0PxTNsSRmlbIhw4pCGqcQmOA3LPOz3s9YiZZLxR2KmhLITCTRJKVKUbo0f1ctEGf6bOa5da3CDVAIvNpUsIjg37wJGMh/rp3ZoCs4J+ecmulfHqKmcx2P6x2uBqgAaGh7CmL2rlOe5F4WBOJQUvej6KJzcbkI1D7zyKXLk2ogKmQKd4vKsw6vxVFu0="
# Karthik
- secure: "OmT4gL0Z4GLC6tZNHQjJzfVQjFsBzWKp1oGnIzW0kClIUiq8gJU6i17M+pMsAondUOn7ALoFxfyFEdtwPfDgGt9pfoO/kHR4fIdldk+v5N4gOSNGDfiso0FGCXgaD3A1JG3kEG4ODv0JShh6KpRi8YwMv0BASyOG9nQwLQu6s5bNzyBnbnAQhQwGx+dzNxA1JWNPx4+EgWArzhdFmfq1/haqMqS6X9Sv1fEnQPH5dsRbTm5+kULqurSbSJ7wxuVnnJgGhc8XWFTZArLlrtxTe4ykfGMu6Rm2PUWw0y80IGZ7DY3C3wloPtBSvF+uO8y/H6ha+eyrF07+roh1l9uWlUVJ8lkn0o0SWKT0/K1tS34JK+oDxQzQWmkJYTR5RdXx6/4f2C/oueZtb8SBSpYxtDrzGBGixIU8lRmcX9x8knA6Tl5fOUlw4MHOqTGTV/oMTgpvaOXN0jGxNWPv0Ud3lMuyD7sgSihdwlFO5rASq0SSqPg4oHogMM/dMW6D5v6/Q3tuMc8hSo9rR9DNws7ktz84Y8TAdrkGWM+jem+ihwzKAjW/ExEbSZzoco8LLqxRtsCmY2Sl21VHGUzbglSvoQfcYhpra//9GLzxyHPZORrdRTMEKBT3SeJgvSb83RNA0Vz1OOzw/JN1JUwQQClrfeGDk6qQuZutbHFYEqvT9TE="
# Francesco
- secure: "grK5n7UwWsw7W/e/MJNh7oMfJgEqocQ4iI9Bc5SD85/eGs8QtyO1wqwt3VZ56LHolbcdojT1arNyrgGZW4z5VLaaAtX5y3Beh286eNv4o8mifGwRoK9UC0nZNTwX0c6zy2A9QGzRAsVAqxcDJIPSEN3Gw+zkU+b8MihO2K5eQnPJRTaOPGf1ZZpDfhwfTHvfWPwxj8qu4z/wcCy4UlYK1C0+ikyH6UInlnVeLLALnu/U6/iN7POvWHaeSaBYrQMB+aFhzEfRY2N3LVRHtbP+TGm5Q+KcGH1cd38axAvN0lLNXpUEvla5d/VjINuCV9R6Nh9JxqmnwSOOh4b1RT15/MA1CnrI9okEMNISBjlED8oVTTA7UQtPhdH9QGhUIkc45yt83mcfdq57JQOUq8lw72NzI0lJ5sIPfDn2H/ucuMVOSkpYmee6hjprpZvyIKD6JjKsq56PjNsFt6wvLhA+O5/bpAXDQVbJIa9ww3veDwFoD9pvtNfc0ocxBz+4C07zZ0kDxNgFHY+N5XY+k8cqoXKSYeMbKggxa6FnffVh2oBvlzOnBRZJOKJBTjPtF2qonzQjJyA5KtJQuQ9xO5a56xbyuNufsJT7vFNWrGzqw0YqWcQnMLWwerdHTKWu0ovaQd3mjtAbm1WvN33d1KPY3YFWoQU6YITwpCi4MjxsJVU="
# Evgeny
- secure: "Ul1D1qkD16wpcuHu+k3qjaHPbeN9oUnofvBJ4OCVMpC4jADtRsuwSKm1gpTApXCoE/scVm2y4qBmwppvzH+m7KQmX1j9T1Al23/KVKUWv241K0pH/MMvF0PFiRIveCG5jwYhAP9KPfYN1zKfmO490zeHp7zRAwWa5fIpx3Ic2WVBLxkU0QNzPZ9ZFWzVPnsP9Mw/QInN1ZQ5lPBdjRe+XOUKR27OiZuYL4mrzBWxkUDn7T8avouYBeYpfqOyLRGegc9C9z1Qz1wkjWBvoAlAy+qt0FwkYE/NdiwAiuircVxw+ASSkfH1lnq4z93HEIfE5jSYomwjGU6LrryMBnn06kmGH0BCG8WHSEuaqTtG+G3Ys2VcPh3erdRXRYSssP6spVgmyOy9z25+snWyrOyiLjr6/ojOWRkjqnnnh1Dqslvsvd8CzmtGTi0F3UjruRezn1K7FmniDx82Po2VWOd1BtoQlmGtSN20ckyOfz8piY1tEmWJ5AllUVPnB5AvEwimYsmZ6bpbWb0k4z9hjdrFivZrzVIT029mzhDB5sALn3xlMXp8P9/v3JznTvNZryYKHG+H5YwuiNVw7Vc+h/VOZCtu1aldX97y5VOgl0SL3Zjo+sYA4te31FGUxwt+MtoTjYfLZtgejmRHcgpMJaJRWHyDMe4Ol4Gmrb6jKKX1GJc="


stages:
- name: linting
Expand Down Expand Up @@ -66,7 +71,12 @@ jobs:
- pyenv global 3.7.1
- pre-commit run --all-files
- stage: system tests
python: '3.7' # only run once.
os: windows
language: shell # 'language: python' is an error on Travis CI Windows
before_install:
- choco install python --version 3.8.2
- python -m pip install --upgrade pip
env: PATH=/c/Python38:/c/Python38/Scripts:$PATH
# use install: from global test stage, since system tests are
# also handled via tox
script:
Expand Down
9 changes: 8 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

## [0.6.3] - 2020-07-01
## [0.6.3] - 2020-07-02

### Changed

Expand All @@ -16,6 +16,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
* CI builds on macOS [#10]
* Move `flake8` and `bandit` entirely to `pre-commit` [#6]
* Fix description on pypi.org and update README [#14]
* System tests added [#18]
* System tests executed on Windows [#21]
* Mail notifications for broken master builds [#20]


## [0.6.2] - 2020-06-30

Expand All @@ -25,6 +29,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

[Unreleased]: https://github.com/SAP/data-attribute-recommendation-python-sdk/compare/v0.6.3...HEAD
[0.6.3]: https://github.com/SAP/data-attribute-recommendation-python-sdk/compare/v0.6.2...0.6.3
[#21]: https://github.com/SAP/data-attribute-recommendation-python-sdk/pull/21
[#20]: https://github.com/SAP/data-attribute-recommendation-python-sdk/pull/20
[#18]: https://github.com/SAP/data-attribute-recommendation-python-sdk/pull/18
[#14]: https://github.com/SAP/data-attribute-recommendation-python-sdk/pull/14
[#6]: https://github.com/SAP/data-attribute-recommendation-python-sdk/pull/6
[#10]: https://github.com/SAP/data-attribute-recommendation-python-sdk/pull/10
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ The name of the virtualenv is now part of your shell prompt.
Finally, install the SDK and its dependencies:

```shell script
(dar-sdk-venv) $ pip install data-attribute-recommendation-python-sdk
(dar-sdk-venv) $ pip install data-attribute-recommendation-sdk
```

If you receive an error message `command not found: pip`, then refer to
Expand Down