Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(platform): Changing default selector prefix for "platform" project #1259

Merged
merged 1 commit into from Sep 12, 2019

Conversation

KevinOkamoto
Copy link
Member

@KevinOkamoto KevinOkamoto commented Sep 12, 2019

Changing the default prefix to "fdp" for "platform".

Please provide a link to the associated issue.

Fixes #1258

Please provide a brief summary of this pull request.

Changed configuration files to help enforce adding "fdp" prefix to all newly generated components for the platform library/project.

If this is a new feature, have you updated the documentation?

N/A

@KevinOkamoto KevinOkamoto added the enhancement New feature or request label Sep 12, 2019
@CLAassistant
Copy link

CLAassistant commented Sep 12, 2019

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@netlify
Copy link

netlify bot commented Sep 12, 2019

Deploy preview for fundamental-ngx ready!

Built with commit 9c2e524

https://deploy-preview-1259--fundamental-ngx.netlify.com

@KevinOkamoto KevinOkamoto changed the title feat: Changing default selector prefix for "platform" project feat(platform): Changing default selector prefix for "platform" project Sep 12, 2019
@KevinOkamoto KevinOkamoto changed the title feat(platform): Changing default selector prefix for "platform" project build(platform): Changing default selector prefix for "platform" project Sep 12, 2019
@KevinOkamoto KevinOkamoto changed the title build(platform): Changing default selector prefix for "platform" project chore(platform): Changing default selector prefix for "platform" project Sep 12, 2019
@fkolar fkolar merged commit 60a2acd into master Sep 12, 2019
@KevinOkamoto KevinOkamoto deleted the enhancement/#1248-change-platform-selector-prefix branch September 12, 2019 18:34
@wizgd wizgd added this to Approved by Reviewer in Platform Development Sep 13, 2019
@wizgd wizgd moved this from Approved by Reviewer to Done in Platform Development Sep 13, 2019
@wizgd wizgd moved this from Done to Approved by Reviewer in Platform Development Sep 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Platform Development
  
Approved by Reviewer
Development

Successfully merging this pull request may close these issues.

Change default selector prefix to "fdp" for "platform" code
3 participants