chore: Added repo arg to the gh-pages call #402
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ument could be passed in
Contributor
Author
|
Per feedback, I made some changes to keep the repo URL construction out of |
jbadan
approved these changes
Feb 13, 2019
greg-a-smith
added a commit
that referenced
this pull request
Mar 5, 2019
* Added repo arg to the gh-pages call * Changed deploy script definition to just run gh-pages so the repo argument could be passed in
ademidun
added a commit
to atilatech/client-web-app
that referenced
this pull request
Aug 31, 2019
based on this PR: SAP/fundamental-react#402
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
gh-pagespackage uses simple authentication by default which was causing thefundamental-botuser to fail authentication when attempting to publish the docs. I added arepoargument that embeds the GitHub token so we can push to thegh-pagesbranch.fixes #352