From 94525254cba02c66da2e761f5aebcaddca524841 Mon Sep 17 00:00:00 2001 From: Ravindra Mitke Date: Tue, 21 Jan 2020 19:46:15 +0530 Subject: [PATCH 1/3] Issue 850: Datepicker triggers form Submission when clicked on month/year button --- src/Calendar/Calendar.js | 12 ++++++++---- src/DatePicker/DatePicker.js | 3 ++- 2 files changed, 10 insertions(+), 5 deletions(-) diff --git a/src/Calendar/Calendar.js b/src/Calendar/Calendar.js index 90ba263b9..78eaa5056 100644 --- a/src/Calendar/Calendar.js +++ b/src/Calendar/Calendar.js @@ -305,14 +305,16 @@ class Calendar extends Component { disableStyles={this.props.disableStyles} glyph='slim-arrow-left' onClick={this.handlePrevious} - option='light' /> + option='light' + typeAttr='button' />
diff --git a/src/DatePicker/DatePicker.js b/src/DatePicker/DatePicker.js index b3318613f..1fc505983 100644 --- a/src/DatePicker/DatePicker.js +++ b/src/DatePicker/DatePicker.js @@ -186,7 +186,8 @@ class DatePicker extends Component { disableStyles={disableStyles} glyph='calendar' onClick={() => this.openCalendar()} - option='light' /> + option='light' + typeAttr='button' /> From f69f68579a8f1abb2abc68b990c0cba0cae95f4d Mon Sep 17 00:00:00 2001 From: Ravindra Mitke Date: Wed, 22 Jan 2020 13:52:17 +0530 Subject: [PATCH 2/3] Issue 850: Added Default props for typeAttr to button in Button component --- src/Button/Button.js | 4 ++++ src/Calendar/Calendar.js | 12 ++++-------- src/DatePicker/DatePicker.js | 3 +-- 3 files changed, 9 insertions(+), 10 deletions(-) diff --git a/src/Button/Button.js b/src/Button/Button.js index 24e050595..b6d60a36a 100644 --- a/src/Button/Button.js +++ b/src/Button/Button.js @@ -57,6 +57,10 @@ Button.propTypes = { onClick: PropTypes.func }; +Button.defaultProps = { + typeAttr: 'button' +}; + Button.propDescriptions = { option: 'Indicates the importance of the button.', selected: 'Set to **true** to set state of the button to "selected".', diff --git a/src/Calendar/Calendar.js b/src/Calendar/Calendar.js index 78eaa5056..90ba263b9 100644 --- a/src/Calendar/Calendar.js +++ b/src/Calendar/Calendar.js @@ -305,16 +305,14 @@ class Calendar extends Component { disableStyles={this.props.disableStyles} glyph='slim-arrow-left' onClick={this.handlePrevious} - option='light' - typeAttr='button' /> + option='light' />
diff --git a/src/DatePicker/DatePicker.js b/src/DatePicker/DatePicker.js index 1fc505983..b3318613f 100644 --- a/src/DatePicker/DatePicker.js +++ b/src/DatePicker/DatePicker.js @@ -186,8 +186,7 @@ class DatePicker extends Component { disableStyles={disableStyles} glyph='calendar' onClick={() => this.openCalendar()} - option='light' - typeAttr='button' /> + option='light' /> From 6fd1c883fc42507adbf451092d09aad0f8c4525b Mon Sep 17 00:00:00 2001 From: Ravindra Mitke Date: Thu, 23 Jan 2020 12:38:01 +0530 Subject: [PATCH 3/3] Issue 850: Updated snapshots --- .../__snapshots__/ActionBar.test.js.snap | 2 + src/Button/Button.js | 4 ++ src/Button/__snapshots__/Button.test.js.snap | 7 ++++ .../__snapshots__/ButtonGroup.test.js.snap | 3 ++ src/Calendar/Calendar.js | 12 ++---- .../__snapshots__/ComboboxInput.test.js.snap | 2 + src/DatePicker/DatePicker.js | 3 +- .../__snapshots__/Dropdown.test.js.snap | 5 +++ .../__snapshots__/InputGroup.test.js.snap | 2 + .../InputGroupAddon.test.js.snap | 2 + .../__snapshots__/ListGroup.test.js.snap | 2 + .../__snapshots__/ListGroupItem.test.js.snap | 1 + .../ListGroupItemActions.test.js.snap | 1 + .../LocalizationEditor.test.js.snap | 3 ++ src/Panel/__snapshots__/Panel.test.js.snap | 2 + .../__snapshots__/PanelActions.test.js.snap | 1 + .../__snapshots__/PanelHeader.test.js.snap | 1 + .../__snapshots__/SearchInput.test.js.snap | 3 ++ .../__snapshots__/Shellbar.test.js.snap | 20 +++++++++ src/Tile/__snapshots__/Tile.test.js.snap | 2 + .../__snapshots__/TileActions.test.js.snap | 1 + src/Time/__snapshots__/Time.test.js.snap | 42 +++++++++++++++++++ .../__snapshots__/TimePicker.test.js.snap | 10 +++++ 23 files changed, 121 insertions(+), 10 deletions(-) diff --git a/src/ActionBar/__snapshots__/ActionBar.test.js.snap b/src/ActionBar/__snapshots__/ActionBar.test.js.snap index d7d9ffc21..7eb6f3f6e 100644 --- a/src/ActionBar/__snapshots__/ActionBar.test.js.snap +++ b/src/ActionBar/__snapshots__/ActionBar.test.js.snap @@ -9,6 +9,7 @@ exports[` create basic Action Bar 1`] = ` > @@ -11,6 +12,7 @@ exports[` @@ -19,6 +21,7 @@ exports[` @@ -27,6 +30,7 @@ exports[` @@ -35,6 +39,7 @@ exports[` @@ -44,6 +49,7 @@ exports[` @@ -53,6 +59,7 @@ exports[` diff --git a/src/Button/__snapshots__/ButtonGroup.test.js.snap b/src/Button/__snapshots__/ButtonGroup.test.js.snap index e9202cf49..2bb196f57 100644 --- a/src/Button/__snapshots__/ButtonGroup.test.js.snap +++ b/src/Button/__snapshots__/ButtonGroup.test.js.snap @@ -8,13 +8,16 @@ exports[` create button group 1`] = ` > @@ -57,6 +58,7 @@ exports[` create dropdown component 2`] = ` onKeyPress={[Function]} role="button" tabIndex={0} + type="button" > Select @@ -90,6 +92,7 @@ exports[` create dropdown component 3`] = ` onKeyPress={[Function]} role="button" tabIndex={0} + type="button" > Select @@ -124,6 +127,7 @@ exports[` create dropdown component 4`] = ` onKeyPress={[Function]} role="button" tabIndex={0} + type="button" > Select @@ -159,6 +163,7 @@ exports[` create dropdown component 5`] = ` onKeyPress={[Function]} role="button" tabIndex={0} + type="button" > Select diff --git a/src/InputGroup/__snapshots__/InputGroup.test.js.snap b/src/InputGroup/__snapshots__/InputGroup.test.js.snap index 733f4b3cd..e1bf56a92 100644 --- a/src/InputGroup/__snapshots__/InputGroup.test.js.snap +++ b/src/InputGroup/__snapshots__/InputGroup.test.js.snap @@ -158,6 +158,7 @@ exports[` create input group items 9`] = ` > @@ -179,6 +180,7 @@ exports[` create input group items 10`] = ` > diff --git a/src/InputGroup/__snapshots__/InputGroupAddon.test.js.snap b/src/InputGroup/__snapshots__/InputGroupAddon.test.js.snap index 4cf2b96bb..24c43d3ae 100644 --- a/src/InputGroup/__snapshots__/InputGroupAddon.test.js.snap +++ b/src/InputGroup/__snapshots__/InputGroupAddon.test.js.snap @@ -14,6 +14,7 @@ exports[` create input group add-on items 2`] = ` > @@ -26,6 +27,7 @@ exports[` create input group add-on items 3`] = ` > diff --git a/src/ListGroup/__snapshots__/ListGroup.test.js.snap b/src/ListGroup/__snapshots__/ListGroup.test.js.snap index 7b5fdf608..3179f1e79 100644 --- a/src/ListGroup/__snapshots__/ListGroup.test.js.snap +++ b/src/ListGroup/__snapshots__/ListGroup.test.js.snap @@ -49,6 +49,7 @@ exports[` create list group 1`] = ` > @@ -81,6 +82,7 @@ exports[` create localization editor 2`] = ` > @@ -125,6 +127,7 @@ exports[` create localization editor 3`] = ` > diff --git a/src/Panel/__snapshots__/Panel.test.js.snap b/src/Panel/__snapshots__/Panel.test.js.snap index 3c90d63b6..0993d57e9 100644 --- a/src/Panel/__snapshots__/Panel.test.js.snap +++ b/src/Panel/__snapshots__/Panel.test.js.snap @@ -26,6 +26,7 @@ exports[` create panels 1`] = ` > @@ -80,6 +81,7 @@ exports[` create panels 2`] = ` > diff --git a/src/Panel/__snapshots__/PanelActions.test.js.snap b/src/Panel/__snapshots__/PanelActions.test.js.snap index 2053c3af3..e95e570e1 100644 --- a/src/Panel/__snapshots__/PanelActions.test.js.snap +++ b/src/Panel/__snapshots__/PanelActions.test.js.snap @@ -6,6 +6,7 @@ exports[` create panel actions 1`] = ` > diff --git a/src/Panel/__snapshots__/PanelHeader.test.js.snap b/src/Panel/__snapshots__/PanelHeader.test.js.snap index d83994b49..af0a34d76 100644 --- a/src/Panel/__snapshots__/PanelHeader.test.js.snap +++ b/src/Panel/__snapshots__/PanelHeader.test.js.snap @@ -23,6 +23,7 @@ exports[` create panels 1`] = ` > diff --git a/src/SearchInput/__snapshots__/SearchInput.test.js.snap b/src/SearchInput/__snapshots__/SearchInput.test.js.snap index ab4037c38..a71dcb502 100644 --- a/src/SearchInput/__snapshots__/SearchInput.test.js.snap +++ b/src/SearchInput/__snapshots__/SearchInput.test.js.snap @@ -34,6 +34,7 @@ exports[` create SearchInput 1`] = `