Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(action bar): adds slots for title and description #258

Merged
merged 1 commit into from Mar 22, 2019

Conversation

suwarnoong
Copy link
Contributor

Please provide a link to the associated issue.

#189

Please provide a brief summary of this pull request.

Adding slots for title and description

@suwarnoong suwarnoong requested a review from a team March 20, 2019 08:17
@CLAassistant
Copy link

CLAassistant commented Mar 20, 2019

CLA assistant check
All committers have signed the CLA.

@suwarnoong
Copy link
Contributor Author

I have been signing the Contributor License many times. But somehow it says it is not signed yet. Anyone any idea?

@jbadan
Copy link
Contributor

jbadan commented Mar 21, 2019

@suwarnoong Have you checked what email is associated with your github account matches your git global config email? You can run git config --list and check that user.email is the same as the on in your github profile settings. If they are different, add the secondary email to your github account and it should resolve itself.

@suwarnoong
Copy link
Contributor Author

@jbadan Yes I just realized there were 2 user.email and user.name in git config. Now it is fixed. Thanks for that

@suwarnoong suwarnoong merged commit 9f0e378 into master Mar 22, 2019
@suwarnoong suwarnoong deleted the fix/action-bar-slots branch March 22, 2019 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants