refactor(python): create python package #5482
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CCFenner
force-pushed
the
python-pkg
branch
3 times, most recently
from
9e2d869 to
90c94a5
Compare
3 tasks
CCFenner
force-pushed
the
python-pkg
branch
8 times, most recently
from
d26e8d5 to
cba72f6
Compare
CCFenner
force-pushed
the
python-pkg
branch
2 times, most recently
from
4dc7bc3 to
391eaf9
Compare
CCFenner
force-pushed
the
python-pkg
branch
from
391eaf9 to
dbd0cdc
Compare
jliempt
reviewed
Sep 19, 2025
cmd/pythonBuild.go
Outdated
|
|
||
| err := createVirtualEnvironment(utils, config, virutalEnvironmentPathMap) | ||
| if err != nil { | ||
| if err := python.CreateVirtualEnvironment(utils.RunExecutable, config.VirutalEnvironmentName); err != nil { |
There was a problem hiding this comment.
Can we fix the typo in VirutalEnvironmentName? With the current parameter name as alias to make it a non-breaking change...
cmd/pythonBuild.go
Outdated
| } | ||
|
|
||
| return nil | ||
| return python.RemoveVirtualEnvironment(utils.RemoveAll, config.VirutalEnvironmentName) |
There was a problem hiding this comment.
Could also be done with defer, in case for example publishing fails.
CCFenner
force-pushed
the
python-pkg
branch
from
3b2d1be to
b759b6e
Compare
jliempt
approved these changes
Sep 23, 2025
|
/it-go |
|
|
/it-go |
yuriy-tereshchuk-sap
pushed a commit
to yuriy-tereshchuk-sap/jenkins-library
that referenced
this pull request
Sep 23, 2025
maxatsap
added a commit
to maxatsap/jenkins-library
that referenced
this pull request
Sep 24, 2025
* origin: feat: add error pattern messages for build and scan steps (SAP#5457) refactor(python): create python package (SAP#5482) fix(python): correct parameter typo (SAP#5485) fix(CxOne): Fix incremental scan count and full scan cycle handling (SAP#5481) CxOne: Update compliance check for audited findings (SAP#5480) Disable TransportSkipVerification in sonarExecuteScan (SAP#5430) fix: Remove `--hide-secret` non-existent flag from helm uninstall (SAP#5478) feat(codeql): ignore paths and scan paths (SAP#5477) chore(renovate): add rule to update python Docker image (SAP#5474) Feat(CxOne): incremental scans based on another branch (SAP#5476)
maxatsap
added a commit
to maxatsap/jenkins-library
that referenced
this pull request
Sep 24, 2025
* origin: feat: add error pattern messages for build and scan steps (SAP#5457) refactor(python): create python package (SAP#5482) fix(python): correct parameter typo (SAP#5485) fix(CxOne): Fix incremental scan count and full scan cycle handling (SAP#5481) CxOne: Update compliance check for audited findings (SAP#5480) Disable TransportSkipVerification in sonarExecuteScan (SAP#5430) fix: Remove `--hide-secret` non-existent flag from helm uninstall (SAP#5478) feat(codeql): ignore paths and scan paths (SAP#5477) chore(renovate): add rule to update python Docker image (SAP#5474) Feat(CxOne): incremental scans based on another branch (SAP#5476)
maxatsap
added a commit
to maxatsap/jenkins-library
that referenced
this pull request
Sep 24, 2025
* origin: feat: add error pattern messages for build and scan steps (SAP#5457) refactor(python): create python package (SAP#5482) fix(python): correct parameter typo (SAP#5485) fix(CxOne): Fix incremental scan count and full scan cycle handling (SAP#5481) CxOne: Update compliance check for audited findings (SAP#5480) Disable TransportSkipVerification in sonarExecuteScan (SAP#5430) fix: Remove `--hide-secret` non-existent flag from helm uninstall (SAP#5478) feat(codeql): ignore paths and scan paths (SAP#5477) chore(renovate): add rule to update python Docker image (SAP#5474) Feat(CxOne): incremental scans based on another branch (SAP#5476)
yuriy-tereshchuk-sap
pushed a commit
to yuriy-tereshchuk-sap/jenkins-library
that referenced
this pull request
Sep 25, 2025
yuriy-tereshchuk-sap
pushed a commit
to yuriy-tereshchuk-sap/jenkins-library
that referenced
this pull request
Sep 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This extracts parts of the python step to an own
pythonpackage and adding dedicated tests.additional changes:
--root-user-action=ignorepythonfrom virtualEnv and install therefore missingwheelpackageChecklist
preliminary to #5463