Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error handling in case the HTML page or QUnit can't be loaded #101

Closed
matz3 opened this issue Aug 23, 2019 · 0 comments · Fixed by #102
Closed

Improve error handling in case the HTML page or QUnit can't be loaded #101

matz3 opened this issue Aug 23, 2019 · 0 comments · Fixed by #102
Assignees

Comments

@matz3
Copy link
Member

matz3 commented Aug 23, 2019

Currently there's an exception in case the HTML page or QUnit can't be loaded

TypeError: Cannot read property 'begin' of undefined

This should be improved within the plugin to log a proper error message.
In addition the test page should be reported as failing and the runner should continue with the next page. Currently it just stops and runs into a timeout.

The detection should differentiate the two scenarios

  • HTML page can't be loaded at all (404)
  • QUnit is not loaded (typeof QUnit === "undefined")
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant