Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uxap.ObjectPageLayout inside m.Dialog increases its height infinitely #2514

Closed
boghyon opened this issue May 12, 2019 · 5 comments
Closed

uxap.ObjectPageLayout inside m.Dialog increases its height infinitely #2514

boghyon opened this issue May 12, 2019 · 5 comments

Comments

@boghyon
Copy link
Contributor

boghyon commented May 12, 2019

URL (minimal example if possible):

https://jsbin.com/ragules/edit?html,js,output

Steps to reproduce the problem:

  1. Open the above JSBin sample
  2. In the output panel, observe how the scroll container of the dialog increases its height infinitely.

Any other information? (attach screenshot if possible)

Aside from the questionable UI choice (putting a whole sap.uxap.ObjectPageLayout inside a Dialog), this behavior occurs only if there are more than one sap.uxap.ObjectPageSubSection controls within the ObjectPageLayout.

@Shtilianova
Copy link
Contributor

Hello @boghyon ,
Thank you for sharing this finding. I've created an internal incident 1980264543. The status of the issue will be updated here in GitHub.
Regards, Diana

@PetyaMarkovaBogdanova
Copy link
Contributor

Hi @boghyon,
the problem comes from the configuration between the wo controls,
because sap.m.Dialog has default scrolling behaviour, which is trigerring content resize event handler
to set the height of its scrolling container, which is forcing the ObjectPageLayout spacer to grow indefinately with its snapping header height, based on current height of the control DOM element. It is bad collaboration between Dialog and OPL, because they are not taking advantage of the only static height they have - the one set on the sap.m.Dialog container.
There is one configuration, that basicly passes this height down in the DOM tree with "100%" height of the scroll containers of the dialog and that way the OPL takes it and calculates on top of it. You should disable all the scrolling inside the dialog, not setting a sap.m.ScrollContainer and stretch the content inside. It is my current resolution, but basicly OPL is designed to work inside a sap.m.Page, where it depends on the viewport height.

You can check it out here: https://jsbin.com/tukuyiy/2/edit?html,js,output

I hope my finding helps you!
Have a nice day!
Regrads,
Petya Bogdanova
(UI5 Developer)

@daniel-cabral
Copy link

daniel-cabral commented Jun 18, 2021

Hey guys!

I've the same issue, but my object page isn't inside a dialog...anyone know some workaround? Using latest SAPUI5.

Code Attached.
supplier-register.view.zip

@xLexip
Copy link

xLexip commented Nov 16, 2022

Hey guys!

I've the same issue, but my object page isn't inside a dialog...anyone know some workaround? Using latest SAPUI5.

Code Attached. supplier-register.view.zip

Hey @daniel-cabral, I'm experiencing a similar phenomenon (v1.108.0), also without a dialog. Were you able to resolve the problem?
BR

@kamalnivasun
Copy link

Please use object page layout inside the page in dialog content.. it will work.. Like below..

</content>
</Page>
</content>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants