Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorial Bug: Downloaded demo project doesn't work OOB #3573

Closed
HymanZHAN opened this issue Aug 12, 2022 · 2 comments
Closed

Tutorial Bug: Downloaded demo project doesn't work OOB #3573

HymanZHAN opened this issue Aug 12, 2022 · 2 comments
Assignees

Comments

@HymanZHAN
Copy link

HymanZHAN commented Aug 12, 2022

Steps to reproduce the problem:

  1. Download the demo app from https://sdk.openui5.org/entity/sap.m.tutorial.walkthrough/sample/sap.m.tutorial.walkthrough.30
  2. Unzip the project, go to the project root and run npm i
  3. Try to start the project with npm start

What is the expected result?

The project should start successfully.

What happens instead?

ui5 serve failed miserably.

Any other information?

> npm start

> sap.m.tutorial.walkthrough.30@1.0.0 start
> ui5 serve


⚠️  Process Failed With Error

Error Message:
Could not find required manifest.json for project sap.m.tutorial.walkthrough.30: ENOENT: no such file or directory, open 'C:\Users\I572233\Downloads\sap.m.tutorial.walkthrough.30\manifest.json'

For details, execute the same command again with an additional '--verbose' parameter

Apparently, the location of manifest.json is incompatible with the config of ui5.yaml, where it says:

specVersion: '2.3'
metadata:
  name: "sap.m.tutorial.walkthrough.30"
type: application
resources:
  configuration:
    paths:
      webapp: .

webapp is configured to the project root, while manifest.json still lives inside the webapp folder.

Additional issues

After starting the downloaded demo project, the following error occurs.

image

Apparently, we don't have a resource folder like the online live project.

image

These issues plague almost every downloaded demo project in the tutorial and can confuse someone new to opnui5 and SAPUI5. Please fix the tutorial's downloadable demo code. Thanks!

@HymanZHAN HymanZHAN changed the title Tutorial Bug: manifest.json is not living in the right directory Tutorial Bug: Downloaded demo project doesn't work OOB Aug 12, 2022
@kskondov
Copy link
Contributor

Hello @HymanZHAN,
Thank you for sharing this finding. I've created an internal incident 2280160353. The status of the issue will be updated here in GitHub.
Regards,
Konstantin

@flovogt flovogt added the bug label Aug 25, 2022
@jdichev jdichev self-assigned this Nov 8, 2022
@jdichev
Copy link
Contributor

jdichev commented Nov 8, 2022

Issue is not reproducible anymore as probably one of the changes on the involved code since it was opened has fixed it.

@jdichev jdichev closed this as completed Nov 8, 2022
@flovogt flovogt added works and removed in progress labels Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants