Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docu enhancement request: How to react to OData SAML timeouts? #958

Open
DerGuteWolf opened this issue Apr 21, 2016 · 21 comments
Open

Docu enhancement request: How to react to OData SAML timeouts? #958

DerGuteWolf opened this issue Apr 21, 2016 · 21 comments

Comments

@DerGuteWolf
Copy link

Could you add to documentation a recommended way to react to OData SAML timeouts from HCP, etc,, cf https://help.hana.ondemand.com/help/frameset.htm?de16793b391a4bcfae6096f34433de76.html under Session Timeout.

I you think this should be better added to the cited page, could you inform your colleagues responsible for this page?

@aborjinik
Copy link
Contributor

aborjinik commented Apr 21, 2016

@DerGuteWolf I cannot judge whether it fits our docu or HCP so I've created an internal incident 1670258252 for this.

@ghost
Copy link

ghost commented Apr 22, 2016

@DerGuteWolf: There is also a "feedback" function at the bottom of the cited page.
Any feedback is directly forwarded to the author of the topic.
image

@DerGuteWolf
Copy link
Author

Yes, I know, already used this several times, but first you there is no interaction (ie I get no feedback and your colleague dealing with this can't get back to me if there are some questions), and second here is also the question where this needed piece of information should be added.,,

@Michadelic
Copy link
Contributor

Hello DerGuteWolf,

thanks again for your suggestion. I took a look at the internal tracking and it has been forwarded to the HCP team who will update their documentation accordingly. Unfortunately they are not using github so i am not sure if you will get another update here.

At least i asked for a status update.

Kind Regards,
Michael

@DerGuteWolf
Copy link
Author

Hi Michael,

just to be sure: the question is if course how to deal with the timeout in an OpenUI5/SAPUI5 ODataModel environment. On this page currently only a jQuery.ajaxComplete example is given.

@DerGuteWolf
Copy link
Author

Is there any progress on this? How should one deal with such authentication ticket timeouts in OpenUI5? As this seems to be done eg on launchpad.support.sap.com it would be nice if you could provide an offical example for this.

@matz3
Copy link
Member

matz3 commented Oct 4, 2016

As far as I could see there is no progress, yet. I will check back if this is something that will be addressed for UI5 specifically.
As there are different approaches used to send requests (XHR, jQuery, datajs) it will be hard to find any common solution except overriding the native XHR and checking for the response codes there. I guess this is also how it was solved in the Launchpad.

@matz3 matz3 self-assigned this Oct 4, 2016
@DerGuteWolf
Copy link
Author

DerGuteWolf commented Feb 12, 2017

Hi!

any progress?

I think for a first version it would be enough if the requests initiated through SAPUI5 would be considered.

Regards,
Wolfgang

@DerGuteWolf
Copy link
Author

Any progress?

@stephania87
Copy link

Thank you for your patience.
HCP has a pattern for handling the session timeout by checking for a certain header and the information is included in their documentation - https://help.sap.com/viewer/65de2977205c403bbc107264b8eccf4b/Cloud/en-US/de16793b391a4bcfae6096f34433de76.html.
Please clarify if the request is to have the recommended handling for your UI5 application of this Session Timeout in UI5 documentation, or general information about detecting the end of a session of a running process, or built-in handling of such cases in SAPUI5.

@DerGuteWolf
Copy link
Author

Well, I referenced this docu page already and already wrote the question is "how to deal with the timeout in an OpenUI5/SAPUI5 ODataModel environment".

The question is eg will jQuery(document).ajaxComplete work with the SAPUI5 OData Models?

Additionaly I find the reloading as suggested in the documentation way too obtrusive, as everythings the user has entered in forms would be lost on reload. launchpad.support.sap,com seems to have a mechanism in place to prevent this.

So, if there is some build-in handling in SAPUI5, I would like to ask for documentation of it, otherwise for some recommended handling.

@DerGuteWolf
Copy link
Author

Any progress here?

@matz3
Copy link
Member

matz3 commented Jan 30, 2018

Not that I know of. I've "pinged" the referenced internal incident, so hopefully there will be an update soon.

@goligo
Copy link
Contributor

goligo commented Feb 2, 2018

The Fiori Launchpad is using a XHR-proxy to intercept all XHR calls sent by UI5. In case one of them gets a response which indicates expired SAML authentication, it is using an iframe to authenticate again and afterwards retries to send the request. This all happens transparently for SAPUI5, for us just the XHR callback is triggered a little later.
There is a backlog item to integrate this feature into SAPUI5, so it can also be used by other applications than the FLP, but it is quite hard to get it working reliably with different kinds of IdPs.

@DerGuteWolf
Copy link
Author

Thanks for the update. IMHO it would we helpful already to have the current FLP implementation available for other/standalone applications even it if only works with SAML 2.0 IdP which indicates the timeout with a configurable header.

@Dev-Nik
Copy link

Dev-Nik commented Apr 17, 2018

We have the same issues here with the session timeout of standalone UI5-Applications. Reload is a poor way to handle this situation. Any progress on the Fiori Launchpad like solution?

@matz3 matz3 removed their assignment Sep 30, 2019
@DerGuteWolf
Copy link
Author

@goligo : Is there any update to the backlog item mentioned in #958 (comment) ?

@goligo
Copy link
Contributor

goligo commented Mar 6, 2020

@DerGuteWolf Sorry, there will be no more updates from me, I have left SAP.

@DerGuteWolf
Copy link
Author

OK, thanks for the answer.
Anybody else @SAP who wants to give an update?

@jviets
Copy link

jviets commented Oct 12, 2020

I feel with you, @DerGuteWolf ! Have the same issue and would appreciate any update...

@flovogt
Copy link
Member

flovogt commented Jul 26, 2022

This issue will be covered in backlog item FIORITECHP1-24618.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

10 participants