Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue # 1282 #1290

Closed
wants to merge 2 commits into from
Closed

Fix for issue # 1282 #1290

wants to merge 2 commits into from

Conversation

krethan
Copy link

@krethan krethan commented Jan 2, 2017

Issue is that safari is not interpreting the CSS correctly on footer; more specifically on class "sapMPageFooter." By adding padding-bottom it will push up the footer and will then display correctly.
We can adjust the CSS through the onAfterRendering function in Page.js in sap.m namespace. However, currently it is hardcoded to 3REM. I will need some input on how to specify the padding dynamically.

@CLAassistant
Copy link

CLAassistant commented Jan 2, 2017

CLA assistant check
All committers have signed the CLA.

Copy link
Author

@krethan krethan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed whitespace

@akudev
Copy link
Contributor

akudev commented May 10, 2017

Issue #1282 has been closed because an App control was used within the UI, but it is meant to only be used as root control (because it sets the size of all parent elements, up to the body and html root element, to 100%). The NavContainer is the same control without this root-level handling and apparently works. So this fix is not needed.

@akudev akudev closed this May 10, 2017
@krethan krethan deleted the issue1282 branch January 2, 2018 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants