New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Page.view.xml #196

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@wefferch
Contributor

wefferch commented Oct 22, 2014

http://stackoverflow.com/questions/25051263/sapui5-tile-container-not-working
Tile Container was not working in original version:
replaced tiles="{ path: '/TileCollection' }" with tiles="{/TileCollection}"

Update Page.view.xml
http://stackoverflow.com/questions/25051263/sapui5-tile-container-not-working
Tile Container was not working in original version:
replaced tiles="{ path: '/TileCollection' }" with tiles="{/TileCollection}"
@akudev

This comment has been minimized.

Contributor

akudev commented Oct 22, 2014

Hi wefferch,

and thanks for the proposal! The original code is not really wrong, but to make it work, an additional switch has to be set in the UI5 bootstrap:
data-sap-ui-xx-bindingSyntax="complex"

This example page, however, does not make any use of the complex binding syntax, so it's better to switch to the plain one, as proposed by you.

Even though the change is very small, I guess we need to follow the rules, so we need you to agree to the contributor license agreement (see https://github.com/SAP/openui5/blob/master/CONTRIBUTING.md#contributor-license-agreement, the very first section only). Please read it and write your agreement (e.g. the proposed sentence) into a comment here, that's enough.

If you are quick, this will be the first external OpenUI5 contribution ever. ;-)

Thanks and regards
Andreas

@wefferch

This comment has been minimized.

Contributor

wefferch commented Oct 22, 2014

Hi Andreas

Thank you for your prompt reply. I am just starting to climb the learning curve of developing on the HANA Cloud Platform, Web IDE & SAPUI5. After replicating the code I couldn't make it work until I found another developer (user3894168) on stackoverflow.com who faced the very same issue. He found some help from another developer Tim Gerlach who pointed out how to handle arrays Data Binding. I reckon is only fair to mention them as they deserve most of the credit.

I just though that I could save some time to other beginners like me by proposing this modification to the code. You mentioned this can also be sort out by adding the Ui5 bootstrap:
data-sap-ui-xx-bindingSyntax="complex"
However when the index.html file is created from the SAPUI5 template the complex binding syntax is not there. As you said just to make it work without any additional changes I reckon it is a good idea to go ahead with the change.

I hereby declare to agree to the OpenUI5 Individual Contributor License Agreement.
It will be a real honor to become the very first external OpenUI5 contributor.

Kind Regards,
Carlos Weffer

@akudev akudev removed the author action label Oct 23, 2014

@balexan

This comment has been minimized.

balexan commented Oct 23, 2014

The change has been merged into the openui5 repository.
Change-Id: I0b4d0ef55a3fe9799813258277cc7d214133c569

Congratulations! This is the FIRST external contribution to OpenUI5!!

@balexan balexan closed this Oct 23, 2014

@akudev akudev added fixed and removed approved labels Oct 23, 2014

@akudev

This comment has been minimized.

Contributor

akudev commented Oct 23, 2014

Merged commit is af12544

@mitsuruog

This comment has been minimized.

mitsuruog commented Oct 23, 2014

Congratulations! @wefferch 👍

akudev referenced this pull request Oct 23, 2014

[FIX] sap.m.TileContainer - Simplify Test Page
Update Page.view.xml

http://stackoverflow.com/questions/25051263/sapui5-tile-container-not-working

Tile Container was not working in original version:

replaced tiles="{ path: '/TileCollection' }" with
tiles="{/TileCollection}"

Change-Id: I0b4d0ef55a3fe9799813258277cc7d214133c569

@akudev akudev removed the bug label Oct 23, 2014

@wefferch

This comment has been minimized.

Contributor

wefferch commented Oct 23, 2014

Thank you all guys.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment