Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hard-Coded UI5 Version (known limitation) #428

Closed
the-docta opened this issue Oct 5, 2021 · 6 comments
Closed

Hard-Coded UI5 Version (known limitation) #428

the-docta opened this issue Oct 5, 2021 · 6 comments

Comments

@the-docta
Copy link

the hard-coded UI5 Version (listed in known limitations of the VSCode Extension)

could we have a preference setting, where we could set the version that is to be used?

something like

UI5LanguageAssistant.codeAssist.ui5version = "1.84.4"

maybe along with "sapui5/openui5" switch

@the-docta
Copy link
Author

link to pull request #413 - I think that one implements just that

@bd82
Copy link
Member

bd82 commented Oct 6, 2021

The #413 is just an early WIP for this topic, one which I unfourntaly did not have time to complete...

@GuillaumedesPommareSAP
Copy link

The #413 is just an early WIP for this topic, one which I unfourntaly did not have time to complete...

Would it be possible to at least upgrade hard-coded version to latest LTS (1.84)? To have something up-to-date, not close to cloud versions, but stable enough ?

@nxthor
Copy link

nxthor commented Apr 20, 2022

Hi!
What about the ui5.yaml file for the used version? I guess every project would have to define the targeted version there anyway, or do I miss cases?

@GuillaumedesPommareSAP
Copy link

Hi! What about the ui5.yaml file for the used version? I guess every project would have to define the targeted version there anyway, or do I miss cases?

A configuration option would be great. How it is done is another story, not everyone is using ui5-cli so not every project defines a ui5.yaml file. Here the main issue is that this extension hardcodes one version of UI5 and has no been updated for a while, so you get error on valid XML files, that is not very useful.

@petermuessig
Copy link
Contributor

The latest version 3.2.1 brings multi-version support for the UI5 Language Assistant. The version is derived from the minUI5Version of the closest manifest.json and resolved against the latest available and supported versions from UI5.

Fixed with PR #472 #469

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants