From 4b45d3232c619287c2f4c29e88309cfc6a0a76d1 Mon Sep 17 00:00:00 2001 From: ilhan orhan Date: Tue, 22 Mar 2022 02:19:04 -0700 Subject: [PATCH] fix(framework): add 72-* font as system styles (#4934) The **72-Bold** font did not apply correctly on stakeholder side in FireFox (see the linked issue for more information.). This can be also reproduced in our test pages by opening the Card test page **in sap_horizon in FireFox** via this [link](https://sap.github.io/ui5-webcomponents/master/playground/main/pages/Card/?sap-ui-theme=sap_horizon). The headings in the Card header should have been bold, however they appear normal instead. The insertion of the **72-Bold, '72-Boldfull', '72-Light' and '72-Lightfull'** fonts explicitly as part of the system vars seem to resolve the issue. The changes is adding the ones that are missing, compared to OpenUi5. FIXES https://github.com/SAP/ui5-webcomponents/issues/4931 --- packages/base/hash.txt | 2 +- packages/base/src/css/FontFace.css | 30 ++++++++++++++++++++++++++++++ 2 files changed, 31 insertions(+), 1 deletion(-) diff --git a/packages/base/hash.txt b/packages/base/hash.txt index a390ae5bcae0..ca61a98768b1 100644 --- a/packages/base/hash.txt +++ b/packages/base/hash.txt @@ -1 +1 @@ -Ymcpo5BI0Vh4B+marW3XQhleQiI= \ No newline at end of file +3A147f62aHRSel1BUKBRiI/tr7o= \ No newline at end of file diff --git a/packages/base/src/css/FontFace.css b/packages/base/src/css/FontFace.css index 154c2ca1822e..1b8d1cc069bc 100644 --- a/packages/base/src/css/FontFace.css +++ b/packages/base/src/css/FontFace.css @@ -35,6 +35,36 @@ url(https://ui5.sap.com/sdk/resources/sap/ui/core/themes/sap_fiori_3/fonts/72-Bold-full.woff?ui5-webcomponents) format("woff"); } +@font-face { + font-family: '72-Bold'; + font-style: normal; + src: local('72-Bold'), + url(https://ui5.sap.com/sdk/resources/sap/ui/core/themes/sap_fiori_3/fonts/72-Bold.woff2?ui5-webcomponents) format("woff2"), + url(https://ui5.sap.com/sdk/resources/sap/ui/core/themes/sap_fiori_3/fonts/72-Bold.woff?ui5-webcomponents) format("woff"); +} + +@font-face { + font-family: '72-Boldfull'; + font-style: normal; + src: url(https://ui5.sap.com/sdk/resources/sap/ui/core/themes/sap_fiori_3/fonts/72-Bold-full.woff2?ui5-webcomponents) format("woff2"), + url(https://ui5.sap.com/sdk/resources/sap/ui/core/themes/sap_fiori_3/fonts/72-Bold-full.woff?ui5-webcomponents) format("woff"); +} + +@font-face { + font-family: '72-Light'; + font-style: normal; + src: local('72-Light'), + url(https://ui5.sap.com/sdk/resources/sap/ui/core/themes/sap_fiori_3/fonts/72-Light.woff2?ui5-webcomponents) format("woff2"), + url(https://ui5.sap.com/sdk/resources/sap/ui/core/themes/sap_fiori_3/fonts/72-Light.woff?ui5-webcomponents) format("woff"); +} + +@font-face { + font-family: '72-Lightfull'; + font-style: normal; + src: url(https://ui5.sap.com/sdk/resources/sap/ui/core/themes/sap_fiori_3/fonts/72-Light-full.woff2?ui5-webcomponents) format("woff2"), + url(https://ui5.sap.com/sdk/resources/sap/ui/core/themes/sap_fiori_3/fonts/72-Light-full.woff?ui5-webcomponents) format("woff"); +} + @font-face { font-family: "72Black"; font-style: bold;