Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
fix(ui5-flexible-column-layout): rename noArrows property to hideArro…
…ws (#3352)

Part of #3107

BREAKING_CHANGE: rename noArrows property to hideArrows
  • Loading branch information
fifoosid committed May 28, 2021
1 parent 39cc473 commit 8660d11
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 5 deletions.
7 changes: 4 additions & 3 deletions packages/fiori/src/FlexibleColumnLayout.js
Expand Up @@ -77,8 +77,9 @@ const metadata = {
* @type {boolean}
* @defaultvalue false
* @public
* @since 1.0.0-rc.15
*/
noArrows: {
hideArrows: {
type: Boolean,
},

Expand Down Expand Up @@ -592,11 +593,11 @@ class FlexibleColumnLayout extends UI5Element {
}

get showStartArrow() {
return this.noArrows ? false : this.startArrowVisibility;
return this.hideArrows ? false : this.startArrowVisibility;
}

get showEndArrow() {
return this.noArrows ? false : this.endArrowVisibility;
return this.hideArrows ? false : this.endArrowVisibility;
}

get startArrowVisibility() {
Expand Down
4 changes: 2 additions & 2 deletions packages/fiori/test/pages/FCL.html
Expand Up @@ -227,11 +227,11 @@

<!-- ex2 -->
<br><br>
<ui5-title class="sectionTitle">Master-Detail: Detail expanded + no-arrows</ui5-title>
<ui5-title class="sectionTitle">Master-Detail: Detail expanded + hide-arrows</ui5-title>
<ui5-toggle-button id="switchBtn2" class="testButton">Set to TwoColumnsMidExpanded</ui5-toggle-button>
<br><br>

<ui5-flexible-column-layout id="fcl2" layout="TwoColumnsMidExpanded" no-arrows>
<ui5-flexible-column-layout id="fcl2" layout="TwoColumnsMidExpanded" hide-arrows>
<!-- start column -->
<div style="box-sizing: border-box;" slot="startColumn">
<div style="padding: 1rem">
Expand Down

0 comments on commit 8660d11

Please sign in to comment.