Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui5-select): add ariaLabel and ariaLabelledby properties #2125

Merged
merged 2 commits into from
Aug 20, 2020

Conversation

ilhan007
Copy link
Member

Similar to other components, the Select should also support aria-label and aria-labelledby set on the custom element.
Note: internally we also set aria-label, using the base method "getEffectiveAriaLabelText" for the purpose.

Related to #2107

@ilhan007 ilhan007 merged commit a58bf49 into master Aug 20, 2020
@ilhan007 ilhan007 deleted the feat-select-arialbl branch August 20, 2020 09:41
ilhan007 added a commit that referenced this pull request Aug 20, 2020
Similar to other components, the Select should also support aria-label and aria-labelledby set on the custom element.
Note: internally we also set aria-label, using the base method "getEffectiveAriaLabelText" for the purpose.

Related to #2107
ilhan007 added a commit that referenced this pull request Oct 17, 2020
Similar to other components, the Select should also support aria-label and aria-labelledby set on the custom element.
Note: internally we also set aria-label, using the base method "getEffectiveAriaLabelText" for the purpose.

Related to #2107
ilhan007 added a commit that referenced this pull request Nov 11, 2020
Similar to other components, the Select should also support aria-label and aria-labelledby set on the custom element.
Note: internally we also set aria-label, using the base method "getEffectiveAriaLabelText" for the purpose.

Related to #2107
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants