fix(ui5-select): fix text color of disabled select in hcb/hcw #2248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilhan007
previously approved these changes
Sep 28, 2020
ilhan007
requested changes
Sep 28, 2020
packages/main/src/themes/Input.css
Outdated
| @@ -44,7 +44,6 @@ | |||
| pointer-events: none; | |||
| background: var(--sapField_ReadOnly_Background); | |||
| border-color: var(--sapField_ReadOnly_BorderColor); | |||
| -webkit-text-fill-color: var(--sapContent_DisabledTextColor); | |||
| color: var(--sapContent_DisabledTextColor); | |||
There was a problem hiding this comment.
According to the latest design, the text color should be --sapField_TextColor (not --sapContent_DisabledTextColor) in Fiori3 HCW and HCB themes in order to see the text, otherwise it is almost unreadable
There was a problem hiding this comment.
--sapField_TextColor is the default colour, so it is not needed to be set explicitly again.
fifoosid
changed the title
ilhan007
approved these changes
Sep 28, 2020
fifoosid
added a commit
that referenced
this pull request
Sep 28, 2020
ilhan007
pushed a commit
that referenced
this pull request
Oct 17, 2020
ilhan007
pushed a commit
that referenced
this pull request
Nov 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2247