Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui5-li-tree): hover and active visual state #3298

Merged
merged 3 commits into from May 28, 2021
Merged

fix(ui5-li-tree): hover and active visual state #3298

merged 3 commits into from May 28, 2021

Conversation

nnaydenow
Copy link
Contributor

@nnaydenow nnaydenow commented May 21, 2021

Styles for active and hover states were limited to the context of ui5-side-navigation. Now, they will be applied to the both components - ui5-side-navigation and ui5-li-tree

Hover and active state should be visible when the item could be selected. In addition the cursor should be pointer only when the expand/collapse icon is hovered or when the item could be selected.

Fixes: #3291

Copy link
Contributor

@fifoosid fifoosid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently we don't have type property for thetreeListItem, but if such property is introduced, the hover effect should be applied only for active TreeListItem

@nnaydenow
Copy link
Contributor Author

Do not submit at the moment! Some alignments should be done.

Copy link
Contributor

@fifoosid fifoosid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some alignment should be done

@nnaydenow nnaydenow requested a review from fifoosid May 27, 2021 12:59
@fifoosid fifoosid merged commit 4ac6d23 into SAP:master May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ui5-li-tree: no hover/active state
2 participants