Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui5-button's styles are broken in sap_belize theme #3482

Closed
1 of 4 tasks
gmkv opened this issue Jul 1, 2021 · 1 comment · Fixed by #3485
Closed
1 of 4 tasks

ui5-button's styles are broken in sap_belize theme #3482

gmkv opened this issue Jul 1, 2021 · 1 comment · Fixed by #3485
Assignees
@tsanislavgatev
Labels
bug This issue is a bug in the code High Prio TOPIC B
Projects
Maintenance - Topic B

Comments

@gmkv
Copy link
Contributor

gmkv commented Jul 1, 2021

Bug Description

The button's styles are broken in the SAP Belize theme.

Steps to Reproduce

  1. Go to https://sap.github.io/ui5-webcomponents/master/playground/main/pages/Button/?sap-ui-theme=sap_belize

Context

  • UI5 Web Components version: latest

Priority

  • Low
  • Medium
  • High
  • Very High

The priority indicates the severity of the issue. To set the appropriate priority consider the following criteria:

  • Breaks entire application or system - High or Very High
  • Accessibility issue - Medium or High
  • Functional issue - Medium or High
  • Visual issue - Low or Medium

Note: The priority might be re-evaluated by the issue processor.
I believe broken CSS styles in this way suffice for at least High priority.
@gmkv gmkv added bug This issue is a bug in the code High Prio TOPIC B labels Jul 1, 2021
@gmkv gmkv added this to New Issues in Maintenance - Topic B via automation Jul 1, 2021
@gmkv
Copy link
Contributor Author

gmkv commented Jul 1, 2021

Hi @SAP/ui5-webcomponents-topic-b. Would you take a look? Looks like an issue with the parameters/css bundle of the theme.

@tsanislavgatev tsanislavgatev self-assigned this Jul 2, 2021
@tsanislavgatev tsanislavgatev moved this from New Issues to In Progress in Maintenance - Topic B Jul 2, 2021
@tsanislavgatev tsanislavgatev mentioned this issue Jul 2, 2021
Merged
Maintenance - Topic B automation moved this from In Progress to Completed Jul 8, 2021
tsanislavgatev added a commit that referenced this issue Jul 8, 2021
@tsanislavgatev
fix(ui5-button): added belize parameters to bundle (#3485)
97a8713 
fixes: #3482
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsanislavgatev tsanislavgatev

Labels
bug This issue is a bug in the code High Prio TOPIC B
Projects
Maintenance - Topic B
  
Completed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ui5-button): added belize parameters to bundle SAP/ui5-webcomponents
2 participants
@tsanislavgatev @gmkv