Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui5-label): allow focusing elements linked with for attribute inside a shadow root #4754

Merged
merged 3 commits into from Feb 16, 2022

Conversation

gmkv
Copy link
Contributor

@gmkv gmkv commented Feb 15, 2022

Fixes: #4751

@gmkv gmkv marked this pull request as ready for review February 15, 2022 14:41
@gmkv gmkv requested a review from a team February 15, 2022 14:41
@gmkv gmkv changed the title fix(ui5-label): focusing elements linked with for attribute now works… fix(ui5-label): focusing elements linked with for attribute inside a shadow root now works Feb 15, 2022
@gmkv gmkv changed the title fix(ui5-label): focusing elements linked with for attribute inside a shadow root now works fix(ui5-label): allow focusing elements linked with for attribute inside a shadow root Feb 15, 2022
@gmkv gmkv closed this Feb 15, 2022
@gmkv gmkv reopened this Feb 15, 2022
@gmkv gmkv merged commit bd7a8a1 into master Feb 16, 2022
@gmkv gmkv deleted the label-for-attr-in-shadow-root branch February 16, 2022 14:56
ilhan007 pushed a commit that referenced this pull request Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ui5-label: "for" relation doesn't work if label&input are within Shadow DOM
2 participants