Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SF][ui5-menu] Menu throws an error in the console when hovering children #5582

Closed
1 of 4 tasks
Neeeko opened this issue Jul 28, 2022 · 1 comment · Fixed by #5591
Closed
1 of 4 tasks

[SF][ui5-menu] Menu throws an error in the console when hovering children #5582

Neeeko opened this issue Jul 28, 2022 · 1 comment · Fixed by #5591
Assignees
Labels
bug This issue is a bug in the code Medium Prio SAP SF TOPIC B

Comments

@Neeeko
Copy link

Neeeko commented Jul 28, 2022

Bug Description

When hovering the "Sub Menu" of a ui5-menu with Sub-menu items, the following error is thrown to the console:

Uncaught TypeError: Cannot read properties of undefined (reading 'hasChildren')

It doesn't seem to break the component behavior.

Expected Behavior

No error should be thrown when using the component.

Steps to Reproduce

  1. Go to https://sap.github.io/ui5-webcomponents/playground/components/Menu/
  2. Press the "Open Menu" button under the "Menu with Sub-menu items" example
  3. Open the dev console
  4. Move your curser over sub items multiple time, see the error in the console

Isolated Example

Screen Recording 2022-07-27 at 5 13 28 PM (1)

Context

  • UI5 Web Components version: 1.6.0
  • OS/Platform: MacOS
  • Browser: Chrome
  • Affected component: ui5-menu

Priority

  • Low
  • Medium
  • High
  • Very High

The priority indicates the severity of the issue. To set the appropriate priority consider the following criteria:

  • Breaks entire application or system - High or Very High
  • Accessibility issue - Medium or High
  • Functional issue - Medium or High
  • Visual issue - Low or Medium

Note: The priority might be re-evaluated by the issue processor.

Stakeholder Info (if applicable)

  • Organization: SuccessFactors
@stbodurov stbodurov self-assigned this Jul 28, 2022
@stbodurov stbodurov added bug This issue is a bug in the code Medium Prio TOPIC B SAP SF labels Jul 29, 2022
@stbodurov
Copy link
Contributor

Hi @SAP/ui5-webcomponents-topic-b,

Could you please take a look at this issue? When the mouseout and mouseover event handlers are invoked for subMenu items, the check for item.hasChildren throws an error, because item is undefined.

To reproduce, go to https://sap.github.io/ui5-webcomponents/main/playground/main/pages/Menu

Regards,
Stanislav

@stbodurov stbodurov added this to New Issues in Maintenance - Topic B via automation Jul 29, 2022
@stbodurov stbodurov removed their assignment Jul 29, 2022
@tsanislavgatev tsanislavgatev self-assigned this Jul 29, 2022
@tsanislavgatev tsanislavgatev moved this from New Issues to In Progress in Maintenance - Topic B Jul 29, 2022
Maintenance - Topic B automation moved this from In Progress to Completed Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug in the code Medium Prio SAP SF TOPIC B
Projects
Development

Successfully merging a pull request may close this issue.

3 participants