Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui5-shellbar): assistant icon color fixed #8746

Merged

Conversation

PetyaMarkovaBogdanova
Copy link
Contributor

As in the new VD spec the color of the assistant in the ui5-shellbar is corrected, when in toggle state "on".

Copy link
Contributor

@vladitasev vladitasev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not mix camelCase and kebab-case. We only use kebab-case for CSS. Also, please fix in the 2.0 branch.

@PetyaMarkovaBogdanova PetyaMarkovaBogdanova merged commit ae0e430 into release-1.24 Apr 26, 2024
9 checks passed
@nnaydenow nnaydenow deleted the fix-shellbar-assistant-color-1.24 branch May 29, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants