refactor: i18n build and ResourceBundle #720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilhan007
changed the title
ilhan007
changed the title
vladitasev
previously approved these changes
Aug 21, 2019
vladitasev
approved these changes
Aug 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
USED_KEYS.txtas we have thei18n-defaults.jsauto generated.i18n-transform.shscript as we get the translations process setup and will receive translations regularly.src/messagebundle_*.jsonfiles, before produced with i18n-transform.shExample:
messagebundle_en.json => {CARD_LABEL: "card", SWITCH_ON: "On", SWITCH_OFF: "Off"}base/ResourceBundle, which does not import core/ResourceBundle anymoreformatMessage,normalize,nextFallbackLocaleMessageBundleAssets.jsto import the generated jsons.