Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests to #57

merged 1 commit into from Nov 28, 2018


Copy link

commented Nov 27, 2018

We have analysed your codebase and have noticed some gaps in the coverage of JavaId

The following tests for this function has been written with the help of Diffblue Cover.

Hopefully these tests should help you detect regressions caused by future code changes. Please let us know if you'd be interested in having more tests written for other classes within the vulnerability-assessment-tool and we would be happy to help.

As per your contribution guidelines, both individual and corporate CLAs have been signed and will be sent to the requested addresses asap.

Add unit tests to
These tests were written by Diffblue Cover.

This comment has been minimized.

Copy link

commented Nov 27, 2018

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.


This comment has been minimized.

Copy link

commented Nov 27, 2018

Thank you very much for the PR and providing the signed CLA per email, I will review all this tomorrow. Cheers, Henrik

@henrikplate henrikplate merged commit e05e28f into SAP:master Nov 28, 2018

1 of 2 checks passed

license/cla Contributor License Agreement is not signed yet.
continuous-integration/travis-ci/pr The Travis CI build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
3 participants
You can’t perform that action at this time.