Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include DpnII and NlaIII digestion site trimming #73

Open
EKingma opened this issue Feb 22, 2022 · 5 comments
Open

Include DpnII and NlaIII digestion site trimming #73

EKingma opened this issue Feb 22, 2022 · 5 comments
Labels
enhancement New feature or request

Comments

@EKingma
Copy link

EKingma commented Feb 22, 2022

Is your feature request related to a problem? Please describe.
DpnII and NlaIII digestion sites should be trimmed during the processing of the data. These sequences should be trimmed to prevent the contamination of the insertion site sequence with plasmid/other sequences which can affect the accurate mapping during alignment

Describe the solution you'd like
Add the possibility to trim sequences after the DpnII and NlaIII digestion sites before mapping

Describe alternatives you've considered

Additional context
image

@leilaicruz leilaicruz added the enhancement New feature or request label Feb 22, 2022
@leilaicruz
Copy link
Member

Thanks for the documenting this enhancement to the pipeline!
For clarification on what you asked for:

Add the possibility to trim sequences after the DpnII and NlaIII digestion sites before mapping

Could this be resolved by adding the sequences of the DpnII and NIaIII restriction sites to the adapter.fa file? , which is where we put everything we would like to trim from the data.

or also we could ,during the preprocessing (during the part of preparing the dataset for the pipeline ) remove those reads that contain a restriction site , either for DpnII or NIaIII.

Let me know your thoughts on that

@EKingma
Copy link
Author

EKingma commented Feb 22, 2022

Thanks for the documenting this enhancement to the pipeline! For clarification on what you asked for:

Add the possibility to trim sequences after the DpnII and NlaIII digestion sites before mapping

Could this be resolved by adding the sequences of the DpnII and NIaIII restriction sites to the adapter.fa file? , which is where we put everything we would like to trim from the data.

or also we could ,during the preprocessing (during the part of preparing the dataset for the pipeline ) remove those reads that contain a restriction site , either for DpnII or NIaIII.

Let me know your thoughts on that

Hi,

Yes possibly that would be a solution, but these sequences need to be right-trimmed, while I believe that the adapters are removed using left-trimming of the sequence. So it would need to adjust for that for the DpnII and NlaIII sites

@leilaicruz
Copy link
Member

Yes, so maybe it is better to remove those reads containing the restriction sites in the pre-processing part and then during the processing in the pipeline just trim the sequencing primer , as we usually do.

@EKingma
Copy link
Author

EKingma commented Feb 22, 2022

Sure, but then it should be mentioned somewhere that this is a step that needs to be done before processing the pipeline

@leilaicruz
Copy link
Member

leilaicruz commented Feb 22, 2022

yes, exactly 👍

See #74

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants