Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emmc and SD card stats #24

Merged
merged 35 commits into from Jul 29, 2021
Merged

Emmc and SD card stats #24

merged 35 commits into from Jul 29, 2021

Conversation

SAtacker
Copy link
Owner

#10

  • Stats
  • Grow Partition

SAtacker and others added 28 commits June 16, 2021 02:18
Squashed commit of the following:

commit 5644e30
Merge: 4f77f9a 35bbd6a
Author: Shreyas Atre <61797109+SAtacker@users.noreply.github.com>
Date:   Sat Jun 12 19:34:34 2021 +0530

    Merge pull request #5 from SAtacker/dev

    UI as per #4
Squashed commit of the following:

commit 06204ef
Author: ArthurSonzogni <sonzogniarthur@gmail.com>
Date:   Sun Jun 27 16:21:44 2021 +0200

    Add a demo for background worker.

    Make use of thread to run operations in the background. Use FTXUI
    Sender/Receiver to send data in between the threads.

    Demo:
    https://asciinema.org/a/Y4DLwmldNHC0LKZzR7cUJx595

commit 02891d9
Author: Shreyas Atre <shreyasatre16@gmail.com>
Date:   Sun Jun 27 22:20:41 2021 +0530

    Cleanup
    * Modified board/CMakeLists.txt
    * Removed board/ui/custom_container

commit 443fb21
Author: ArthurSonzogni <sonzogniarthur@gmail.com>
Date:   Wed Jun 23 21:58:08 2021 +0200

    Modularize

commit 5644e30
Merge: 4f77f9a 35bbd6a
Author: Shreyas Atre <61797109+SAtacker@users.noreply.github.com>
Date:   Sat Jun 12 19:34:34 2021 +0530

    Merge pull request #5 from SAtacker/dev

    UI as per #4
* Test for connecting & disconnecting (demo link below)
[![asciicast](https://asciinema.org/a/422909.svg)](https://asciinema.org/a/422909)
* UI is currently facing issue as shown
[![asciicast](https://asciinema.org/a/423111.svg)](https://asciinema.org/a/423111)
* This is probably due to the input output streams messing up
* Results are still the same
* UI breaks on invoking the subprocess
[![asciicast](https://asciinema.org/a/423963.svg)](https://asciinema.org/a/423963)
* Relies on Connman
* Possible issuses : Connman may take over some additional services causing undef
	             behaviour.
* Possible Workarounds / Sol : Add extra functionality to backup resolv.conf and
				others that can be manipulated by Connman
* Checks if wlan0 interface is present
[![asciicast](https://asciinema.org/a/426246.svg)](https://asciinema.org/a/426246)
* Removed obsolete comment
* Improved namings in func @ L345
* Added `reduce` and `trim` as free functions under `utils`
* Inlining of reused definitions is not done as I would prefer it to remain above so that even if I look after a long time it won't make a mess.
> I made it constexpr instead of const because the former is mainly associated with compile-time optimization as well as I thought of it as demacrofication in CPP whereas the latter has the freedom to be initialized at runtime. Arthur absolutely right that it's not much use as I assume that both will be optimized here but considering the use case I made it constexpr.
* Depends on /opt/scripts/tools/grow_partitions.sh
* Removed definitions from src/utils.hpp to src/utils.cpp

Demo:
https://asciinema.org/a/427430
https://asciinema.org/a/427432
@SAtacker SAtacker added the enhancement New feature or request label Jul 27, 2021
@SAtacker SAtacker added this to In Progress in beagle-config via automation Jul 27, 2021
@ArthurSonzogni
Copy link
Contributor

Thanks!
I will take a look. I am trying it locally, but I don't see anything being displayed. I am trying to debug.

@SAtacker SAtacker merged commit 945670e into main Jul 29, 2021
beagle-config automation moved this from In Progress to Done Jul 29, 2021
@SAtacker SAtacker deleted the emmc-sd branch July 29, 2021 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
beagle-config
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants