Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Floating panel height doesn’t update when large title navigation bar shrinks to normal size from scrolling #28

Closed
Kohdepitcher opened this issue Nov 2, 2018 · 3 comments

Comments

@Kohdepitcher
Copy link

commented Nov 2, 2018

When trying out the floating panel, the panel’s height is correct and the bottom safe area sticks to the screen correctly as seen in this screen shot...
d74a2ede-3769-493f-b074-8f3e5fbf9b8f

But when the large title navigation bar shrinks to the normal size due to scrolling the collection view on my home VC, pulling up the floating panel quickly causes the bottom safe area constraint to be above the bottom of the screen as seen in this screen shot... notice the large grey bar underneath the pink button, that shouldn’t be there
a09c7dec-1957-4a11-ae2f-e5eed206c32b

But when panning the floating panel, it snaps back down so that the bottom of my stack view touches the bottom safe area of the home vc as the stack view in the floating panel has a constraint to the bottom safe area of the floating panel. This snapping also causes the floating panel to ignore my 18 point gap inset between the top of the panel and the nav bar which is set in the panel’s custom layout
48c55dce-98f0-489c-b201-1418299d0a18

@SCENEE

This comment has been minimized.

Copy link
Owner

commented Nov 2, 2018

Thank you for your report. I fixed this issue on PR #29

@Kohdepitcher

This comment has been minimized.

Copy link
Author

commented Nov 2, 2018

Only just changed my Podfile to the fix-navigation-bar-problem branch and had some weird bad access codes when trying to use a floating panel object but that was fixed by just de-integrating and reinstalling my pods. I can confirm that your solution has fixed this issue of the floating panel being affected by the changing height of the navigation bar. Cheers mate. Just need to try your other fix for the translucency affecting the positioning. Definitely some awesome work by you.

@SCENEE

This comment has been minimized.

Copy link
Owner

commented Nov 4, 2018

Thank you for your confirmation! Could you try my other fix for #26 ?

@SCENEE SCENEE closed this Nov 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.