Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed disappearing scene #2001

Merged
merged 5 commits into from Oct 7, 2019

Conversation

@RubioJr9
Copy link
Contributor

commented Sep 30, 2019

It was normalizing a zero vector if movement was small.

Tested on:

  • Mac
  • Linux
RubioJr9 and others added 2 commits Sep 30, 2019
RubioJr9
@dcwhite dcwhite requested review from dcwhite and jessdtate Sep 30, 2019
@dcwhite dcwhite self-assigned this Sep 30, 2019
@dcwhite dcwhite added the Graphics label Sep 30, 2019
@dcwhite dcwhite added this to the 5.0-beta.X [Internal] milestone Sep 30, 2019
@dcwhite dcwhite added this to Critical Bugs in Renderer/Visualization Sep 30, 2019
tpat and others added 2 commits Oct 1, 2019
tpat
@dcwhite

This comment has been minimized.

Copy link
Member

commented Oct 4, 2019

To test, move single pixel at a time.

@dcwhite

This comment has been minimized.

Copy link
Member

commented Oct 4, 2019

Merge today

@jessdtate

This comment has been minimized.

Copy link
Contributor

commented Oct 4, 2019

I can still get it to disappear with the zoom on mac. I think it is less frequent though.

@dcwhite

This comment has been minimized.

Copy link
Member

commented Oct 4, 2019

So no merge today?

@jessdtate

This comment has been minimized.

Copy link
Contributor

commented Oct 4, 2019

I put a cout statement. Sometimes the angle is nan still. When I added that check, I haven't been able to get it to disappear.
if(angle <= 0.00001 || std::isnan(angle))

@jessdtate

This comment has been minimized.

Copy link
Contributor

commented Oct 4, 2019

I guess we can merge it and make the fix.

@RubioJr9

This comment has been minimized.

Copy link
Contributor Author

commented Oct 4, 2019

I can fix it now

@RubioJr9

This comment has been minimized.

Copy link
Contributor Author

commented Oct 4, 2019

Done

@dcwhite

This comment has been minimized.

Copy link
Member

commented Oct 4, 2019

Thanks guys

@dcwhite
dcwhite approved these changes Oct 7, 2019
@dcwhite dcwhite merged commit 1c76199 into SCIInstitute:master Oct 7, 2019
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
Renderer/Visualization automation moved this from Critical Bugs to Done Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
3 participants
You can’t perform that action at this time.