Weight assignment fix #98
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 10, 2022 12:46
jessdtate
previously approved these changes
Feb 16, 2022
jessdtate
reviewed
Feb 17, 2022
Contributor
Author
|
That actually is correct -- but that demo uses a terribly high order (not sure why I set it that way), so I updated that, and also changed the demo to line up with the new, simplified |
jessdtate
approved these changes
Feb 18, 2022
dcwhite
approved these changes
Feb 18, 2022
ZEXINLIU
approved these changes
Feb 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where weights are not assigned if user manually sets samples.