New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix problem with Install and multiple dirs outside src tree. #3044

Merged
merged 1 commit into from Jan 5, 2018

Conversation

Projects
None yet
3 participants
@garyo
Contributor

garyo commented Jan 5, 2018

In some cases it's possible to get a case where the target
path already does exist, but the dir node for it hasn't been
updated yet. This fix prevents MkdirFunc from trying to create
it when it already exists. Added a testcase which failed before
the fix and works after it.

Also fixes a problem running tests on Windows, using standard
python 3 which is installed in "C:/Program Files/Python36".
The python path name has to be escaped in that case. See runtest.py.

Gary Oberbrunner
Fix problem with Install and multiple dirs outside src tree.
In some cases it's possible to get a case where the target
path already does exist, but the dir node for it hasn't been
updated yet. This fix prevents MkdirFunc from trying to create
it when it already exists. Added a testcase which failed before
the fix and works after it.

Also fixes a problem running tests on Windows, using standard
python 3 which is installed in "C:/Program Files/Python36".
The python path name has to be escaped in that case. See runtest.py.
@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jan 5, 2018

Coverage Status

Coverage increased (+2.0%) to 61.821% when pulling 25887d9 on garyo:master into 91d1191 on SCons:master.

coveralls commented Jan 5, 2018

Coverage Status

Coverage increased (+2.0%) to 61.821% when pulling 25887d9 on garyo:master into 91d1191 on SCons:master.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jan 5, 2018

Coverage Status

Coverage remained the same at 59.838% when pulling 25887d9 on garyo:master into 91d1191 on SCons:master.

coveralls commented Jan 5, 2018

Coverage Status

Coverage remained the same at 59.838% when pulling 25887d9 on garyo:master into 91d1191 on SCons:master.

@bdbaddog bdbaddog merged commit 87bfc91 into SCons:master Jan 5, 2018

2 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 59.838%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment