Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quiet Py3 resource warnings #3279

Merged
merged 1 commit into from Jan 26, 2019

Conversation

Projects
None yet
3 participants
@mwichmann
Copy link
Collaborator

commented Jan 25, 2019

Later Pythons (3.6+) enable warnings by default (needed a command
line option before then), so some tools give off warnings now.
This change quiets the warnings from the gcc, g++ and swig tools.

Signed-off-by: Mats Wichmann mats@linux.com

Contributor Checklist:

  • [n/a] I have created a new test or updated the unit tests to cover the new/changed functionality.
  • I have updated master/src/CHANGES.txt directory (and read the README.txt in that directory)
  • [n/a] I have updated the appropriate documentation
Quiet Py3 resource warnings
Later Pythons (3.6+) enable warnings by default (needed a command
line option before then), so some tools give off warnings now.
This change quiets the warnings from the gcc, g++ and swig tools.

Signed-off-by: Mats Wichmann <mats@linux.com>
@@ -11,6 +11,10 @@ RELEASE VERSION/DATE TO BE FILLED IN LATER

- Whatever John Doe did.

From Mats Wichmann:
- Quiet open file ResourceWarnings on Python >= 3.6 caused by

This comment has been minimized.

Copy link
@bdbaddog

bdbaddog Jan 25, 2019

Contributor

Instead of "Quiet" how about Resolve?

This comment has been minimized.

Copy link
@mwichmann

mwichmann Jan 25, 2019

Author Collaborator

I can do that if you want...

This comment has been minimized.

Copy link
@bdbaddog

bdbaddog Jan 25, 2019

Contributor

Looks good. Merging.

@bdbaddog

This comment has been minimized.

Copy link
Contributor

commented Jan 25, 2019

Looks good.
Almost feels like a utility routine to get tools versions might be useful?
You could pass in command line flag, tool name, and regex?

@bdbaddog

This comment has been minimized.

Copy link
Contributor

commented Jan 25, 2019

Waiting for CI. Assuming all good will merge.

@coveralls

This comment has been minimized.

Copy link

commented Jan 25, 2019

Coverage Status

Coverage increased (+1.5%) to 81.509% when pulling c3c5c76 on mwichmann:open-file-warnings into 32646d6 on SCons:master.

@mwichmann

This comment has been minimized.

Copy link
Collaborator Author

commented Jan 26, 2019

I see in https://travis-ci.org/SCons/scons/jobs/484531435 that all but the warnings on .sconsign.dblite are gone.

@bdbaddog bdbaddog merged commit e44c771 into SCons:master Jan 26, 2019

5 checks passed

Sider No issues found!
Details
WIP Ready for review
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+1.5%) to 81.509%
Details

mwichmann added a commit to mwichmann/scons that referenced this pull request Feb 8, 2019

Fix some more subprocess-unclosed-file warnings
Following on to PR SCons#3279 which cleaned up warnings for gcc, g++
and swig by using context managers, do the same for Windows vc.

Signed-off-by: Mats Wichmann <mats@linux.com>

@mwichmann mwichmann referenced this pull request Feb 8, 2019

Merged

Fix some more subprocess-unclosed-file warnings #3297

3 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.