Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools should not override existing path order #3280

Closed
wants to merge 2 commits into from

Conversation

@dmoody256
Copy link
Contributor

@dmoody256 dmoody256 commented Jan 27, 2019

This is a potential solution to #3276.

This sets all tools to not delete existing paths, maintaining the original environment.

  • I have created a new test or updated the unit tests to cover the new/changed functionality.
  • I have updated master/src/CHANGES.txt directory (and read the README.txt in that directory)
  • I have updated the appropriate documentation
@coveralls
Copy link

@coveralls coveralls commented Jan 27, 2019

Coverage Status

Coverage decreased (-0.0009%) to 79.984% when pulling 41280fe on dmoody256:tools_path_appending_issue into e44c771 on SCons:master.

@bdbaddog
Copy link
Contributor

@bdbaddog bdbaddog commented Jan 27, 2019

Is there anywhere left in scons where delete_existing is defaulted?
Perhaps it makes more sense to change the default?
I can't imagine that the "normal" usage would want to move it to the end of a given path?

@dmoody256
Copy link
Contributor Author

@dmoody256 dmoody256 commented Jan 28, 2019

Is there anywhere left in scons where delete_existing is defaulted?
Perhaps it makes more sense to change the default?
I can't imagine that the "normal" usage would want to move it to the end of a given path?

I made another to test that out PR #3281

@dmoody256
Copy link
Contributor Author

@dmoody256 dmoody256 commented Jan 29, 2019

I think I will close this PR in favor of changing the default and updating the test in #3281?

@bdbaddog
Copy link
Contributor

@bdbaddog bdbaddog commented Jan 29, 2019

O.k. Closing.

@bdbaddog bdbaddog closed this Jan 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants