Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Changes to address failing tests in appveyor #34
Your changes will disable and/or break tests which do complete successfully on our windows buildbot workers and on properly configured machines.
Plus I really don't like huge pull requests which affect many different tests. Ideally you'd address the comments and make sure that the changes aren't disabling tests which work outside the appveyor environment.
The goal is not that only the tests which function in the appveyor environment run, but rather that tests which can pass will run in any environment which can run them and get skipped in those that cannot.
None of the failed test in the buildbot you linked were modified in this PR, and I dont see any underlying files in this PR which could have affected those tests on buildbot.
I addressed your review comments, if there are certain changes in this PR you feel are changing the tests to disable or break them in other environments, we could check one of the appveyor environment variables and skip the test in those cases for appveyor so as to leave the test the same on other environments, but still be able to get passing results from appveyor.