New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -W support #36

Closed
wants to merge 4 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@dmoody256
Contributor

dmoody256 commented Dec 30, 2017

This issue was originally created at: 2001-09-23 22:00:00.
This issue was reported by: stevenknight.
stevenknight said at 2001-09-23 22:00:00

The extremely cool GNU what-if option, showing what would be built if a file was changed. We should be able to do this easily by just adding a random (or hard-coded) value to the signature.

issues@scons said at 2001-09-23 22:00:00

Converted from SourceForge task item 39031

coverage reports have been missing the coverage data located in the t…
…mp test dirs, so this change makes sure those data files get included in the report.
@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Dec 30, 2017

Coverage Status

Coverage increased (+20.5%) to 80.324% when pulling 1a6de1b on dmoody256:CoverageImprovements into a3f0e74 on SCons:master.

coveralls commented Dec 30, 2017

Coverage Status

Coverage increased (+20.5%) to 80.324% when pulling 1a6de1b on dmoody256:CoverageImprovements into a3f0e74 on SCons:master.

@bdbaddog

This comment has been minimized.

Show comment
Hide comment
@bdbaddog

bdbaddog Dec 31, 2017

Contributor

wouldn't setting COVERAGE_FILE be simpler?

http://coverage.readthedocs.io/en/coverage-4.2/cmd.html#data-file

Coverage.py collects execution data in a file called ”.coverage”. If need be, you can set a new file name with the COVERAGE_FILE environment variable. This can include a path to another directory.

Contributor

bdbaddog commented Dec 31, 2017

wouldn't setting COVERAGE_FILE be simpler?

http://coverage.readthedocs.io/en/coverage-4.2/cmd.html#data-file

Coverage.py collects execution data in a file called ”.coverage”. If need be, you can set a new file name with the COVERAGE_FILE environment variable. This can include a path to another directory.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Dec 31, 2017

Coverage Status

Coverage increased (+20.5%) to 80.332% when pulling 573c051 on dmoody256:CoverageImprovements into a3f0e74 on SCons:master.

coveralls commented Dec 31, 2017

Coverage Status

Coverage increased (+20.5%) to 80.332% when pulling 573c051 on dmoody256:CoverageImprovements into a3f0e74 on SCons:master.

@dmoody256

This comment has been minimized.

Show comment
Hide comment
@dmoody256

dmoody256 Dec 31, 2017

Contributor

It seemed that wouldn't work with the multi-process run, because that section also says:

By default, each run of your program starts with an empty data set.

And the next section talks about combining coverage data from multiple processes:
https://coverage.readthedocs.io/en/coverage-4.2/cmd.html#combining-data-files

If you need to collect coverage data from different machines or processes, coverage.py can combine multiple files into one for reporting.

I didn't try using the COVERAGE_FILE file because it didn't seem that multiple processes writing to one file was how it was intended to work due to concurrency issues of which files have io access or which data gets written when.

Contributor

dmoody256 commented Dec 31, 2017

It seemed that wouldn't work with the multi-process run, because that section also says:

By default, each run of your program starts with an empty data set.

And the next section talks about combining coverage data from multiple processes:
https://coverage.readthedocs.io/en/coverage-4.2/cmd.html#combining-data-files

If you need to collect coverage data from different machines or processes, coverage.py can combine multiple files into one for reporting.

I didn't try using the COVERAGE_FILE file because it didn't seem that multiple processes writing to one file was how it was intended to work due to concurrency issues of which files have io access or which data gets written when.

@bdbaddog

This comment has been minimized.

Show comment
Hide comment
@bdbaddog

bdbaddog Dec 31, 2017

Contributor
Contributor

bdbaddog commented Dec 31, 2017

@dmoody256

This comment has been minimized.

Show comment
Hide comment
@dmoody256

dmoody256 Dec 31, 2017

Contributor

I tested the coverage_file env var and it worked, I'll update the travis script to use that as it is a bit simpler

Contributor

dmoody256 commented Dec 31, 2017

I tested the coverage_file env var and it worked, I'll update the travis script to use that as it is a bit simpler

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jan 1, 2018

Coverage Status

Coverage increased (+24.3%) to 84.138% when pulling a90dd65 on dmoody256:CoverageImprovements into a3f0e74 on SCons:master.

coveralls commented Jan 1, 2018

Coverage Status

Coverage increased (+24.3%) to 84.138% when pulling a90dd65 on dmoody256:CoverageImprovements into a3f0e74 on SCons:master.

3 similar comments
@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jan 1, 2018

Coverage Status

Coverage increased (+24.3%) to 84.138% when pulling a90dd65 on dmoody256:CoverageImprovements into a3f0e74 on SCons:master.

coveralls commented Jan 1, 2018

Coverage Status

Coverage increased (+24.3%) to 84.138% when pulling a90dd65 on dmoody256:CoverageImprovements into a3f0e74 on SCons:master.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jan 1, 2018

Coverage Status

Coverage increased (+24.3%) to 84.138% when pulling a90dd65 on dmoody256:CoverageImprovements into a3f0e74 on SCons:master.

coveralls commented Jan 1, 2018

Coverage Status

Coverage increased (+24.3%) to 84.138% when pulling a90dd65 on dmoody256:CoverageImprovements into a3f0e74 on SCons:master.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jan 1, 2018

Coverage Status

Coverage increased (+24.3%) to 84.138% when pulling a90dd65 on dmoody256:CoverageImprovements into a3f0e74 on SCons:master.

coveralls commented Jan 1, 2018

Coverage Status

Coverage increased (+24.3%) to 84.138% when pulling a90dd65 on dmoody256:CoverageImprovements into a3f0e74 on SCons:master.

@bdbaddog bdbaddog changed the title from Coverage is missing coverage files from tmp test dirs to Add -W support Jan 2, 2018

@bdbaddog bdbaddog closed this Jan 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment