Make browser windows use Chrome-like user agent#146
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Browser windows now use a Chrome-like user agent derived from Electron's current Chromium UA, with Electron/app product tokens removed. Added a fixture test that compares the normalized UA exactly against an equivalent real Chrome UA.
Motivation
Sites that check
navigator.userAgentor request headers should see Lightcode's in-app browser as real Chrome instead of Electron.Testing
pnpm exec vitest run src/main/browser/userAgent.test.tspnpm exec vitest run src/main/browser/userAgent.test.ts src/main/browser/BrowserTab.test.ts src/main/browser/BrowserPanelManager.test.ts src/main/window/createMainWindow.test.tspnpm run typecheckpnpm run lintpnpm run fmt:checkpnpm run testxvfb-run google-chrome ... /json/versionreturnedMozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/148.0.0.0 Safari/537.36.Screenshots
Not applicable; main-process browser UA behavior is covered by automated tests and terminal-driven Chrome comparison.
Linked issue
Closes #