Sync terminal xterm palette with app theme CSS variables#95
Merged
Conversation
- Read background, foreground, and cursor from shared CSS custom properties - Re-apply theme on appearance or preset change after AppProvider updates vars
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
The new theme-sync effect assigns `terminal.options.theme` via requestAnimationFrame. The xterm mock never set `this.options`, so the deferred callback threw `Cannot set properties of undefined`, surfacing as 7 unhandled errors that failed the test run even though all specs passed. Mirror the real Terminal by exposing the constructor options as `this.options`. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type: Bugfix
themePresetor resolved appearance updates.