From 40524876e9a66fa6dbf0eb6980cd98071a9d7923 Mon Sep 17 00:00:00 2001 From: Olivier Poitrey Date: Thu, 6 Sep 2012 22:49:04 +0200 Subject: [PATCH] Add some security around wrongly typed URL argument --- SDWebImage/SDWebImageManager.m | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/SDWebImage/SDWebImageManager.m b/SDWebImage/SDWebImageManager.m index e61f01486..08226adb6 100644 --- a/SDWebImage/SDWebImageManager.m +++ b/SDWebImage/SDWebImageManager.m @@ -123,6 +123,10 @@ - (void)downloadWithURL:(NSURL *)url delegate:(id)del { url = [NSURL URLWithString:(NSString *)url]; } + else if (![url isKindOfClass:NSURL.class]) + { + url = nil; // Prevent some common crashes due to common wrong values passed like NSNull.null for instance + } if (!url || !delegate || (!(options & SDWebImageRetryFailed) && [failedURLs containsObject:url])) {