Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary CGImage check when encode first frame #2609

Merged

Conversation

zhongwuzw
Copy link
Member

New Pull Request Checklist

  • I have read and understood the CONTRIBUTING guide

  • I have read the Documentation

  • I have searched for a similar pull request in the project and found none

  • I have updated this branch with the latest master to avoid conflicts (via merge from master or rebase)

  • I have added the required tests to prove the fix/feature I am adding

  • I have updated the documentation (if necessary)

  • I have run the tests and they pass

  • I have run the lint and it passes (pod lib lint)

This merge request fixes / reffers to the following issues: ...

Pull Request Description

Revert issue in #2602 .

@dreampiggy From yours comment, you said UIAniamtedImage always return nil when call CGImage, I check it and found it returns the first UIImage's CGImage, which means frames.firstObject.image.CGImage equals to image.CGImage.

@zhongwuzw zhongwuzw requested a review from a team January 29, 2019 14:11
@dreampiggy
Copy link
Contributor

Seems your're right. I run the test case again. It works.

image

By the time I create that #2602, I run the test cases but found that SDGIFImageCoder will get a UIAnimatedImage instance, which CGImage property is nil. It's a little strange... 😕

For now,just revert this until we can reproduce that case again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants