Supports built-in WebP/AWebP codec from ImageIO for iOS 14/tvOS 14/macOS 11/watchOS 7 #3048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dreampiggy
added
WebP
animated image
ImageIO
dreampiggy
commented
Jul 3, 2020
| @@ -112,7 +90,7 @@ | |||
| debugDocumentVersioning = "YES"> | |||
| <RemoteRunnable | |||
| runnableDebuggingMode = "2" | |||
| BundleIdentifier = "com.apple.carousel" | |||
| BundleIdentifier = "com.apple.Carousel" | |||
There was a problem hiding this comment.
This diff is caused by Xcode 12 update. And seems does not effect the user who use Xcode 11.
dreampiggy
force-pushed
the
feature_webp_ios14
branch
from
91d5fb1
to
7bfd67a
Compare
…eb Encoding currently
|
During test, seems Image/IO support does not supports encoding. This is limited by Image/IO, hope future we can have built-in WebP encoding as well.
|
|
Fired Radar: FB7844481
|
dreampiggy
force-pushed
the
feature_webp_ios14
branch
from
2b829f1
to
d09ff5a
Compare
Codecov Report
@@ Coverage Diff @@
## master #3048 +/- ##
==========================================
- Coverage 83.51% 83.24% -0.27%
==========================================
Files 69 70 +1
Lines 7589 7593 +4
==========================================
- Hits 6338 6321 -17
- Misses 1251 1272 +21
Continue to review full report at Codecov.
|
kinarobin
reviewed
Jul 6, 2020
kinarobin
reviewed
Jul 6, 2020
…method with Set to check, instead of creating different internal files
kinarobin
approved these changes
Jul 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Pull Request Checklist
I have read and understood the CONTRIBUTING guide
I have read the Documentation
I have searched for a similar pull request in the project and found none
I have updated this branch with the latest master to avoid conflicts (via merge from master or rebase)
I have added the required tests to prove the fix/feature I am adding
I have updated the documentation (if necessary)
I have run the tests and they pass
I have run the lint and it passes (
pod lib lint)This merge request fixes / refers to the following issues: #3041
Pull Request Description
This close #3041
Changes
Similiar to HEIC, iOS 14's new WebP codec can be implementes with the subclass of
SDAnimatedImageIOCoder.ThekUTTypeWebPdoes not get defined by Apple's SDK (bugs?), but I found the raw string value for that isorg.webmproject.webp, so we define one with macroThe UTI API is here: https://developer.apple.com/documentation/uniformtypeidentifiers/uttypewebp
However, we need to support Xcode 11 :) So we hardcode the raw value with macro.
For macOS, we can supports the NSImageView rendering with
SDAnimatedImageRepas well.Also, this PR changes one possible previouslly wrong design, now, the
SDImageIOCoderas a default backup, does not check any format and always pass it to system and try to decode, no need hack forHEIC, orWebP.Run result on iPhone Simulator with iOS 14: