Fix the bug that when querying original cache miss, the download process will be skipped. This is not designed behavior. #3221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ess will be skipped. This is not designed behavior.
dreampiggy
force-pushed
the
bugfix_original_cache_miss_continue_download
branch
from
d09f8e2
to
896c5f6
Compare
kinarobin
approved these changes
Apr 23, 2021
Codecov Report
@@ Coverage Diff @@
## master #3221 +/- ##
==========================================
- Coverage 83.31% 83.29% -0.02%
==========================================
Files 70 70
Lines 7724 7728 +4
==========================================
+ Hits 6435 6437 +2
- Misses 1289 1291 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Seems the test case now works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Pull Request Checklist
I have read and understood the CONTRIBUTING guide
I have read the Documentation
I have searched for a similar pull request in the project and found none
I have updated this branch with the latest master to avoid conflicts (via merge from master or rebase)
I have added the required tests to prove the fix/feature I am adding
I have updated the documentation (if necessary)
I have run the tests and they pass
I have run the lint and it passes (
pod lib lint)This merge request fixes / refers to the following issues: ...
Pull Request Description
This is a bug that breaks current transformer function.
Seems related to #2360 refactory changes. Mistake code.