From e98a2ea6e183bbed2b8db07c86a6ac62b59f6709 Mon Sep 17 00:00:00 2001 From: John Date: Fri, 16 Dec 2022 19:52:19 +0800 Subject: [PATCH 1/2] fix transition not working --- SDWebImageSwiftUI/Classes/ImageManager.swift | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/SDWebImageSwiftUI/Classes/ImageManager.swift b/SDWebImageSwiftUI/Classes/ImageManager.swift index d9bce8fa..ada7976e 100644 --- a/SDWebImageSwiftUI/Classes/ImageManager.swift +++ b/SDWebImageSwiftUI/Classes/ImageManager.swift @@ -77,7 +77,9 @@ public final class ImageManager : ObservableObject { // So previous View struct call `onDisappear` and cancel the currentOperation return } - self.image = image + withAnimation { + self.image = image + } self.error = error self.isIncremental = !finished if finished { From 7b918952d0e66c31502b8eb399e30ba8c2bf14ac Mon Sep 17 00:00:00 2001 From: John Date: Wed, 21 Dec 2022 09:48:02 +0800 Subject: [PATCH 2/2] Update ImageManager.swift --- SDWebImageSwiftUI/Classes/ImageManager.swift | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/SDWebImageSwiftUI/Classes/ImageManager.swift b/SDWebImageSwiftUI/Classes/ImageManager.swift index ada7976e..5699643d 100644 --- a/SDWebImageSwiftUI/Classes/ImageManager.swift +++ b/SDWebImageSwiftUI/Classes/ImageManager.swift @@ -77,9 +77,9 @@ public final class ImageManager : ObservableObject { // So previous View struct call `onDisappear` and cancel the currentOperation return } - withAnimation { +// withAnimation { self.image = image - } +// } self.error = error self.isIncremental = !finished if finished {