Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI/CD Workflow for Main Repository #63

Closed
R055A opened this issue Mar 19, 2022 · 0 comments · Fixed by #64
Closed

Fix CI/CD Workflow for Main Repository #63

R055A opened this issue Mar 19, 2022 · 0 comments · Fixed by #64
Assignees
@R055A
Labels
bug Something isn't working
Milestone
Assignment 1

Comments

@R055A
Copy link
Contributor

R055A commented Mar 19, 2022

There is a missing statement for setting sequential testing that should be in line 118 in .github/workflows/node.js.yml:

max-parallel: 1

This is the result from hours of trying different strategies for deploying to Heroku when push and manual workflows dispatch events are triggered in the main branch of the main repository while also keeping different strategies for pull request events to the main branch in the main repository and for push events to any branch in fork repositories.
@R055A R055A added the bug Something isn't working label Mar 19, 2022
@R055A R055A added this to the Assignment 1 milestone Mar 19, 2022
@R055A R055A self-assigned this Mar 19, 2022
@R055A R055A mentioned this issue Mar 19, 2022
Merged
11 tasks
@R055A R055A linked a pull request Mar 19, 2022 that will close this issue
Fix CI/CD sequential testing #64
Merged
11 tasks
@R055A R055A closed this as completed in #64 Mar 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@R055A R055A

Labels
bug Something isn't working
Projects
None yet
Milestone
Assignment 1
Development

Successfully merging a pull request may close this issue.

Fix CI/CD sequential testing
1 participant
@R055A